On Sun, Aug 27, 2017 at 05:28:12PM +0300, Dmitry V. Levin wrote: > On Sun, Aug 27, 2017 at 09:27:43PM +0800, JingPiao Chen wrote: > > On Wed, Aug 23, 2017 at 04:09:03AM +0300, Dmitry V. Levin wrote: > > > On Fri, Aug 18, 2017 at 04:43:56PM +0800, JingPiao Chen wrote: > > > > The place where should review stricter: > > > > > > > > * decode_ifla_address(): AF_INET and AF_INET6 address print format. > > > > * decode_rtnl_link_ifmap(): mpersify struct rtnl_link_ifmap. > > > > * tests: test address should change the header message, I use two global > > > > variable to achieve this goal. > > > > > > > > JingPiao Chen (2): > > > > rtnl_link: decode ifinfomsg netlink attributes > > > > tests: check decoding of ifinfomsg netlink attributes > > > > > > > > Makefile.am | 1 + > > > > configure.ac | 6 + > > > > rtnl_link.c | 259 > > > > +++++++++++++++++++++++++++++++++++++++- > > > > sizeof_struct_rtnl_link_ifmap.c | 44 +++++++ > > > > tests/gen_tests.in | 2 +- > > > > tests/nlattr_ifinfomsg.c | 221 > > > > +++++++++++++++++++++++++++++++++- > > > > 6 files changed, 528 insertions(+), 5 deletions(-) > > > > create mode 100644 sizeof_struct_rtnl_link_ifmap.c > > > > > > This is a kind reminder to submit the next iteration of this parser soon, > > > while I still remember details. > > > > Sorry, I faced with difficult. > > What kind of difficulty?
* Do not understand some netlink attribute data. * Current nla decoder can not decode netlink attribute that depend on other netlink attribute. Such as RTA_ENCAP and IFLA_INFO_DATA. * I can not find a good way to test attribute that carry sub-attribute, like IFLA_PROTINFO. > > > Need I cut the patch send the code that I think is ok? > > Yes, please. -- JingPiao Chen ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
