Re: [PATCH v13 1/4] Prepare for adding support for Lua scripting

[Dmitry V. Levin]

On Fri, Sep 15, 2017 at 04:10:05PM +0300, Victor Krapivensky wrote:
[...]
> diff --git a/syscall.c b/syscall.c
> index b1047feb..abc3f80c 100644
> --- a/syscall.c
> +++ b/syscall.c
[...]
> +#if SUPPORTED_PERSONALITIES > 1
> +
> +const char *const personality_names[] =
> +# if defined POWERPC64
> +     {"64 bit", "32 bit"}
> +# elif defined X86_64
> +     {"64 bit", "32 bit", "x32"}
> +# elif defined X32
> +     {"x32", "32 bit"}
> +# elif defined AARCH64
> +     {"64 bit", "32 bit"}
> +# elif defined TILE
> +     {"64-bit", "32-bit"}
> +# else
> +#  error Add personality names for your achitecture.
> +# endif
> +     ;
[...]
> @@ -307,21 +393,10 @@ update_personality(struct tcb *tcp, unsigned int 
> personality)
>               return;
>       tcp->currpers = personality;
>  
> -# undef PERSONALITY_NAMES
> -# if defined X86_64
> -#  define PERSONALITY_NAMES {"64 bit", "32 bit", "x32"}
> -# elif defined X32
> -#  define PERSONALITY_NAMES {"x32", "32 bit"}
> -# elif SUPPORTED_PERSONALITIES == 2
> -#  define PERSONALITY_NAMES {"64 bit", "32 bit"}
> -# endif
> -# ifdef PERSONALITY_NAMES

Why do you essentially revert commits v4.19~57 and v4.19~52 here?


-- 
ldv

signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel