Sounds fine to me.

Tim Fennell wrote:
Hey Ben,

I think probably we should actually make the member private and provide a protected getter method for it. I'm not a big fan of protected members (it's just that much harder to read and figure out where they come from, not to mention making it harder to change the storage in future). It's my bad - I probably should have made it private from the start!

I'll make this change now (yell if you object).

-t

On Mar 5, 2007, at 10:32 PM, [EMAIL PROTECTED] wrote:

Revision: 484
          http://svn.sourceforge.net/stripes/?rev=484&view=rev
Author:   bengunter
Date:     2007-03-05 19:32:12 -0800 (Mon, 05 Mar 2007)

Log Message:
-----------
Resolved STS-329: OnwardResolution should expose the Parameters Map.
The "parameters" map was package private; changed to protected.

Modified Paths:
--------------
trunk/stripes/src/net/sourceforge/stripes/action/ OnwardResolution.java

Modified: trunk/stripes/src/net/sourceforge/stripes/action/ OnwardResolution.java
===================================================================
--- trunk/stripes/src/net/sourceforge/stripes/action/ OnwardResolution.java 2007-03-06 03:26:15 UTC (rev 483) +++ trunk/stripes/src/net/sourceforge/stripes/action/ OnwardResolution.java 2007-03-06 03:32:12 UTC (rev 484)
@@ -35,7 +35,7 @@
  */
public abstract class OnwardResolution<T extends OnwardResolution<T>> {
     protected String path;
-    Map<String,Object> parameters = new HashMap<String,Object>();
+ protected Map<String,Object> parameters = new HashMap<String,Object>();

     /**
* Default constructor that takes the supplied path and stores it for use.


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.

---------------------------------------------------------------------- ---
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php? page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to