> I did move the cleanup code into FlashScope, but I put it in > requestComplete() since the cleanup was occurring right after > requestComplete() was being called. I can put it in its own method if > you think it shouldn't be in requestComplete(). Sounds fine to me. I was really just looking for more of the control to move into FlashScope.
> I also came to the conclusion that ConcurrentHashMap would be the best > choice. Ehhhxcellent. -t > > -Ben > > Tim Fennell wrote: >> That sounds fine. I'll take care of it - it shouldn't take but five >> minutes. >> >> As for the sync issues that Andy brought up - I looked at the one >> where we're iterating over the FlashScopes and purging them, and I >> think the easiest/best solution is to just switch the implementation >> to using ConcurrentHashMap instead of HashMap (it's probably faster >> than anything we'd write to wrap synchronization around a Map). >> >> Along those lines, it might be nice to move the purging logic into >> the FlashScope class and just have the filter call a >> removeExpiredScopes() method or something similar...that way all the >> code is inside FlashScope, and the concurrency issues should be >> clearer.... >> >> -t >> >> On Mar 27, 2007, at 8:32 AM, Ben Gunter wrote: >> >> >>> Hey, Tim. This one is a quick fix, and it has bitten me *many* >>> times in >>> development. Let's add this to the list for 1.4.3. I'll do it if >>> nobody >>> else wants to. >>> >>> http://stripes.mc4j.org/jira/browse/STS-312 >>> >>> Ben Gunter wrote: >>> >>>> I think I should have the flash scope bug fix done by the >>>> weekend. In >>>> fact, it's already working, but I'm now looking at some of the >>>> synchronization issues that Andy pointed out yesterday. I think >>>> we're >>>> right on schedule. I'll take a quick look at the bug list and see >>>> if I >>>> can spot anything else that should be included in 1.4.3. >>>> >>>> -Ben >>>> >>>> Tim Fennell wrote: >>>> >>>> >>>>> Hey Guys, >>>>> >>>>> I'd like to release 1.4.3 this weekend if possible. I just went >>>>> through and finished up fixing the remaining bugs (they were all >>>>> really simple). That means the last one left is the FlashScope >>>>> bug >>>>> that Ben's working on. Ben: is there anything I can do to >>>>> help? Or >>>>> do you think you'll be able to finish this up before the weekend? >>>>> >>>>> Also, Aaron: it looks like you didn't merge the fix for STS-314 >>>>> (options-collection NPE) on to the 1.4.x branch. If you're >>>>> busy or >>>>> not sure how to do that yet, I can do it - just let me know. >>>>> >>>>> Lastly, if there are any important bugs out there that are not >>>>> assigned to 1.4.3 but you believe should be (no new functionality, >>>>> just really annoying/blocking bugs) let me know and I'll try to >>>>> take >>>>> a look at them. >>>>> >>>>> -t >>>>> >>>>> >>>>> >>>> ------------------------------------------------------------------- >>>> -- >>>> ---- >>>> Take Surveys. Earn Cash. Influence the Future of IT >>>> Join SourceForge.net's Techsay panel and you'll get the chance to >>>> share your >>>> opinions on IT & business topics through brief surveys-and earn >>>> cash >>>> http://www.techsay.com/default.php? >>>> page=join.php&p=sourceforge&CID=DEVDEV >>>> _______________________________________________ >>>> Stripes-development mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/stripes-development >>>> >>>> >>> -------------------------------------------------------------------- >>> -- >>> --- >>> Take Surveys. Earn Cash. Influence the Future of IT >>> Join SourceForge.net's Techsay panel and you'll get the chance to >>> share your >>> opinions on IT & business topics through brief surveys-and earn cash >>> http://www.techsay.com/default.php? >>> page=join.php&p=sourceforge&CID=DEVDEV >>> _______________________________________________ >>> Stripes-development mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/stripes-development >>> >> >> >> --------------------------------------------------------------------- >> ---- >> Take Surveys. Earn Cash. Influence the Future of IT >> Join SourceForge.net's Techsay panel and you'll get the chance to >> share your >> opinions on IT & business topics through brief surveys-and earn cash >> http://www.techsay.com/default.php? >> page=join.php&p=sourceforge&CID=DEVDEV >> _______________________________________________ >> Stripes-development mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/stripes-development >> > > ---------------------------------------------------------------------- > --- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to > share your > opinions on IT & business topics through brief surveys-and earn cash > http://www.techsay.com/default.php? > page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Stripes-development mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/stripes-development ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Stripes-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/stripes-development
