Hi Remi,

> Could you associate your updates to open issues in the JIRA (or create
> new ones) and send us some patches ? I'm particularly interested in
> your solution for the _sourcePage param, as it'd boost the development
> of the Clean URLs stuff... and I'd be happy to integrate your patch if
> everything is ok.

I knew you would jump on the sourcePage part *LOL*

As I said, I think it would be best to introduce attributes to <s:form> 
to control this behavior, so no real patches for now :) I just did some 
dirty find'n'replaces to make my current app work :)

I just replaced the simple line
        
out.write( request.getServletPath());

with

out.write(CryptoUtil.encrypt(request.getServletPath(), request));

in FormTag#doEndTag() and accordingly adjusted getSourcePageResolution() 
in my ActionBeanContext implementation like this:

...
sourcePage = CryptoUtil.decrypt(sourcePage, getRequest());
...

To be honest, I wonder why we use the sourcePage parameter at all...Why 
not store the concrete sourcePage directly in the http session? The only 
problem I see is a in a multi-window/multi-(concurrent)-form application.

I think it would be nice to configure the sourcePage behavior in the 
form tag, with options like "none", "session", "encryptedRequest", 
"clearRequest").

> Hence, the question : does everyone here agree on the fact that
> validation isn't necessary for <s:link> ? I do, as it's the dev.'s
> responsability to ensure that the links he/she generates are valid. In
> case of users hack ing the urls, a good old error page is sufficient
> IMHO, no need for supporting error messages etc. as far as I see...

Full ack. :)


Before I log JIRA issues regarding the HttpSession creation I'd like to 
hear (read :) what Tim's thinking about this...


Sebastian


-- 
Sebastian Beigel // Software Architekt
(F) Die Firma GmbH // Innovative Kommunikation
Schwalbacher Straße 74 // D-65183 Wiesbaden
T +49.6 11.2 38 50.24 // F +49.6 11.2 38 50.11
mailto:[EMAIL PROTECTED] // http://www.diefirma.de

Amtsgericht Wiesbaden // HRB 1091
GF // M. Fischer, J. Fritz, C. Kepper, C. Kremers, M. Wenig

Kurze Pause gefällig?
www.neckermann.de/krimi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to