[ http://mc4j.org/jira/browse/STS-431?page=comments#action_10941 ] Ben Gunter commented on STS-431: --------------------------------
I've thought some more about this, and I think the best thing is to mirror the behavior of c:url, which I believe was the idea behind this tag in the first place. To that end, I tested the following JSP code: <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"%> <%@ taglib prefix="s" uri="http://stripes.sourceforge.net/stripes.tld"%> <h1>c:url</h1> <ul> <li><c:url value="/urltest.jsp"> <c:param name="a" value="b" /> <c:param name="c" value="d" /> <c:param name="e" value="f" /> </c:url></li> <li><c:url var="url" value="/urltest.jsp"> <c:param name="a" value="b" /> <c:param name="c" value="d" /> <c:param name="e" value="f" /> </c:url>${url}</li> <li><c:url var="url" value="/urltest.jsp"> <c:param name="a" value="b" /> <c:param name="c" value="d" /> <c:param name="e" value="f" /> </c:url><c:out escapeXml="false" value="${url}" /></li> <li><c:url var="url" value="/urltest.jsp"> <c:param name="a" value="b" /> <c:param name="c" value="d" /> <c:param name="e" value="f" /> </c:url><c:out value="${url}" /></li> </ul> <h1>s:url</h1> <ul> <li><s:url value="/urltest.jsp"> <s:param name="a" value="b" /> <s:param name="c" value="d" /> <s:param name="e" value="f" /> </s:url></li> <li><s:url var="url" value="/urltest.jsp"> <s:param name="a" value="b" /> <s:param name="c" value="d" /> <s:param name="e" value="f" /> </s:url>${url}</li> <li><s:url var="url" value="/urltest.jsp"> <s:param name="a" value="b" /> <s:param name="c" value="d" /> <s:param name="e" value="f" /> </s:url><c:out escapeXml="false" value="${url}" /></li> <li><s:url var="url" value="/urltest.jsp"> <s:param name="a" value="b" /> <s:param name="c" value="d" /> <s:param name="e" value="f" /> </s:url><c:out value="${url}" /></li> </ul> Which yielded the following HTML <h1>c:url</h1> <ul> <li>/stripes-test/urltest.jsp?a=b&c=d&e=f</li> <li>/stripes-test/urltest.jsp?a=b&c=d&e=f</li> <li>/stripes-test/urltest.jsp?a=b&c=d&e=f</li> <li>/stripes-test/urltest.jsp?a=b&c=d&e=f</li> </ul> <h1>s:url</h1> <ul> <li>/stripes-test/urltest.jsp?a=b&c=d&e=f</li> <li>/stripes-test/urltest.jsp?a=b&c=d&e=f</li> <li>/stripes-test/urltest.jsp?a=b&c=d&e=f</li> <li>/stripes-test/urltest.jsp?a=b&c=d&e=f</li> </ul> As you can see, the result is the same for both c:url and s:url. In my opinion, this isn't about whether or not s:url should or should not encode XML characters. It is about whether the behavior of s:url is consistent with the behavior of c:url. Since it is consistent, I don't consider this a bug. > link and url tags generate URLs that are not XHTML compliant > ------------------------------------------------------------ > > Key: STS-431 > URL: http://mc4j.org/jira/browse/STS-431 > Project: Stripes > Issue Type: Bug > Components: Tag Library > Affects Versions: Release 1.5, Release 1.4.3 > Environment: N/A > Reporter: Alan Burlison > Assigned To: Ben Gunter > > For XHTML compliance, all URLs need to be encoded to use "&" instead of > "&". Because Stripes doesn't do this, no document that uses the Stripes > "link" or "url" tags will be XHTML compliant. > See http://www.htmlhelp.com/tools/validator/problems.html#amp -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://mc4j.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 _______________________________________________ Stripes-development mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/stripes-development
