[ http://mc4j.org/jira/browse/STS-460?page=all ]

Tim Fennell resolved STS-460.
-----------------------------

    Resolution: Not a Bug

This is absolutely not a bug.  Where possible Stripes will always 'set to null' 
values for which there is no value in the request.  Strings are not treated 
specially, nor in my opinion should they be.

> Empty form text fields give null String values
> ----------------------------------------------
>
>                 Key: STS-460
>                 URL: http://mc4j.org/jira/browse/STS-460
>             Project: Stripes
>          Issue Type: Improvement
>          Components: ActionBean Dispatching
>    Affects Versions: Release 1.4.3
>         Environment: Windows/Linux, Tomcat 5.5.25
>            Reporter: Phil Sladen
>         Assigned To: Tim Fennell
>
> I can understand that empty form fields give rise to empty objects when there 
> is a converter involved and invalid input, but it seems a bit OTT to also 
> treat Strings the same way. Although String is not a native type, it is 
> treated as such in some respects in the language, and I think Stripes should 
> do the same by default. Otherwise, code is going to be littered with checks 
> for null or be forced to use something like StringUtils. I would however 
> expect the String to be left unaltered, and possibly null, if the 
> corresponding parameter is not provided in the request. I could then choose 
> whether such extra checks are warranted for Strings as well as other objects.
> Instead, I found the most convenient way around the issue was to provide my 
> own PropertyBinder:
> public class MyPropertyBinder extends DefaultActionBeanPropertyBinder {
>         protected void bindNullValue(ActionBean bean, String property, Class 
> type)
>                         throws ExpressionException {
>                 if (type == String.class) {
>                         BeanUtil.setPropertyValue(property, bean, new 
> String());
>                 }
>                 else {
>                         super.bindNullValue(bean, property, type);
>                 }
>         }
> }
> All credit due to Stripes extensibility, but I don't think I should have to 
> do this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://mc4j.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services
for just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to