[ 
http://www.stripesframework.org/jira/browse/STS-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11164#action_11164
 ] 

Alan Burlison commented on STS-427:
-----------------------------------

Ah! I see why I couldn't get this to work, the missing bit is that I wasn't 
walking up the superclasses. Obvious once you have it pointed out :-)

The only thing that I can see that needs tweaking is this comment in the 
tests/src/net/sourceforge/stripes/test/TestGenericBean.java class, which is now 
incorrect as you've fixed the bug:

 * XXX If this class is not the top level in the inheritance hierarchy,
 * Stripes cannot bind its properties. e.g. if instead of:
 * public class TestGenericBean<A,B> { ... }
 * we have
 * class Class1<A,B> { ... }
 * class Class2<B,A> extends Class1<B,A> {}
 * class Class3<X,Y> extends Class2<X,Y> {}
 * public class TestGenericBean<A,B> extends Class3<A,B> {}
 * Stripes will fail to bind the properties of Class1 correctly. See STS-427

Very, very nice work Tim :-)

> Even with STS-426 fixed, Stripes doesn't deal with generic Beans that use 
> inheritance
> -------------------------------------------------------------------------------------
>
>                 Key: STS-427
>                 URL: http://www.stripesframework.org/jira/browse/STS-427
>             Project: Stripes
>          Issue Type: Bug
>    Affects Versions: Release 1.4.3, Release 1.5
>         Environment: OpenSolaris
> Tomcat 5.5.17
>            Reporter: Alan Burlison
>            Assignee: Tim Fennell
>             Fix For: Release 1.5
>
>         Attachments: STS-427.patch
>
>
> STS-426 covered the case where Stripes needed to handle a bean of the form 
> MyBean<A,B>, and provides a fix for that issue.  However, if MyBean inherits 
> from another class, Stripes fails to bind any of its properties, e.g.
> class Class1<A,B> { ... }
> class Class2<B,A> extends Class1<B,A> {}
> class Class3<X,Y> extends Class2<X,Y> {}
> public class MyBean<A,B> extends Class3<A,B> {}
> See the file net.sourceforge.stripes.test.TestGenericBean for an example of 
> how to construct a test case to trigger this bug.
> See also http://mc4j.org/jira/browse/STS-426

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to