Avoid session creation in MessagesTag#getMessages
-------------------------------------------------

                 Key: STS-502
                 URL: http://www.stripesframework.org/jira/browse/STS-502
             Project: Stripes
          Issue Type: Sub-task
          Components: Tag Library
    Affects Versions: Release 1.5
            Reporter: Sebastian Beigel


MessagesTag#getMessages() tries to look up the list of messages in the session 
if none are found in the request. This lookup should only occur if there is a 
session present!

        if (messages == null) {
            messages = (List<Message>) request.getSession().getAttribute( 
getKey() );
            request.getSession().removeAttribute( getKey() );
        }

should become

        if (messages == null && request.getSession(false) != null) {
            ...

(change on line 151 in current Stripes 1.5b1)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to