[
http://www.stripesframework.org/jira/browse/STS-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11354#action_11354
]
Frederic Daoud commented on STS-551:
------------------------------------
Well first of all, I think there's something missing in the code:
InputTagSupport tag = getParentTag(InputTagSupport.class);
while (name == null && tag != null) {
name = tag.getName();
tag = getParentTag(InputTagSupport.class); // shouldn't this line be added?
}
I'm assuming that getParentTag would return null when eventually the top of the
stack is reached.
Second, if the name is null after getting out of that loop, as Frank mentioned,
we should signal the problem in a clear way.
Right now I think an NPE would be thrown.
> Possible infinite loop in
> net.sourceforge.stripes.tag.InputTagSupport.getValidationMetadata()
> ---------------------------------------------------------------------------------------------
>
> Key: STS-551
> URL: http://www.stripesframework.org/jira/browse/STS-551
> Project: Stripes
> Issue Type: Bug
> Affects Versions: Release 1.5
> Environment: Stripes 1.5b1 release
> Reporter: Frank Pavageau
> Priority: Minor
> Fix For: Release 1.5
>
>
> I triggered an infinite loop in
> net.sourceforge.stripes.tag.InputTagSupport.getValidationMetadata() (lines
> 267-270 in 1.5b1, 278-281 in svn today):
> InputTagSupport tag = getParentTag(InputTagSupport.class);
> while (name == null && tag != null) {
> name = tag.getName();
> }
> This was using a <s:options-collection> inside an <s:select>. Obviously, the
> name attribute was somehow missing on the <s:select>, but there might be
> better ways than an infinite loop to tell me :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
