[ 
http://www.stripesframework.org/jira/browse/STS-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11683#action_11683
 ] 

Remi VANKEISBELCK commented on STS-651:
---------------------------------------

Looks pretty tricky. 

Check :
MapPropertyAccessor.getKey(NodeEvaluation) : at line 90, it attempts to use a 
Type Converter in order to convert the map's key. 

The DateTypeConverter is used, and of course, it returns a validation error, 
but this one is ignored. 
The converted value is used only if conversion succeeded without validation 
errors. Otherwise, it defaults to the node's "typed value", which in this case 
is a String.

This is because at parsing time, Stripes finds default basic datatypes using 
regexps. 
See PropertyExpression, line 214. 


> binding invalid Date as a key to Map<Date,Date> breaks the map invariant
> ------------------------------------------------------------------------
>
>                 Key: STS-651
>                 URL: http://www.stripesframework.org/jira/browse/STS-651
>             Project: Stripes
>          Issue Type: Bug
>    Affects Versions: Release 1.5.1, Release 1.6
>            Reporter: Remi VANKEISBELCK
>            Assignee: Remi VANKEISBELCK
>
> When binding an invalid Date (e.g. 'notadate') as a key to a Map<Date,Date> 
> property of an action bean, the TypeConverter fails to convert, but errors 
> are 'ignored', and a String object is added as akey of the map. This violates 
> the map's invariant, and generates a ClassCastException. 
> checked in unit test that reproduces in r.1053 :
> net.sourceforge.stripes.controller.InvalidDateKeyBreaksInvariant_STS_651#bindInvalidDateKeysInMapBreaksMapInvariant
> The @Test annotation is currently commented out, in order to avoide breaking 
> the build. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to