[
http://www.stripesframework.org/jira/browse/STS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11987#action_11987
]
Timothy Stone commented on STS-751:
-----------------------------------
Indeed. I got stuck shortly after Ben's recommendation of a singular tag, e.g.,
<s:options ...>.
I revisited this just last week with the recent activity on the list and I
think I have a solution that I need to actually put into a working application
for smoke testing (possibly today)
I wanted something that was "set and forget" (as much as possible like Struts).
Initially, I thought that the LayoutDefinition would be a good place, but
nested definitions and the framework seemed to lose scope of the request where
the attribute was set. It was always coming back null for the attribute.
Ben had misgivings about placing the attribute in the Layout tags, and I had
misgivings about an <s:options ...> tag. it felt too much like the HTML select
element tag extension, <s:option ...> (where one might see <s:options ...> as a
way to have single tag in an <s:select ...>).
I have started looking at the <s:form ...> a bit more. The issue lies in the
input elements generated by Stripes out-of-the-box in <s:form...> or <s:form
partial='true' ...>, not with template text that might be in a Layout tag.
My current approach adds a new attribute to <s:form ...>. Input tags can get
the parent form tag via getParentFormTag and then can call an overridden
writeSingletonTag method, or set it's own PageScope'd variable that can branch
the existing element terminator based on the form element.
I'll have something for review EOD or tomorrow.
> Add support ala Struts to generate HTML or XHTML compliant close tags
> ---------------------------------------------------------------------
>
> Key: STS-751
> URL: http://www.stripesframework.org/jira/browse/STS-751
> Project: Stripes
> Issue Type: Improvement
> Components: Tag Library
> Affects Versions: Release 1.5
> Environment: No specific OS required; no specific Java version
> required; etc...
> Reporter: Nikolaos
> Priority: Minor
> Attachments: stripes-html4-input-0.1.jar, stripes-xhtml-patch.tar.gz,
> stripes-xhtml-patches.tar.gz
>
>
> HTML and XHTML documents have some key differences.
> For example - if we consider the <input> tag:
> - In HTML, the <input> tag has no end tag e.g. <input name="website.url"
> type="text" size="30">
> - In XHTML, the <input> tag must be properly closed, like this <input />
> e.g. <input name="website.url" type="text" size="30" />
> Stripes 1.5.x however does not have a mechanism to discern whether or not to
> properly close tags or not and as such takes the safer approach which is to
> explicitly close tags as it results in valid XHTML and is not an error for
> HTML but results in a warning when validating HTML documents. Although the
> latter is not a critical issue it does result in needless or unnecessary
> complaints when validating and as such is an annoyance albeit minor.
> Struts since 1.x has solved this issue quite easily by allowing the inclusion
> of the xhtml="true" attribute to mark that closure is required (false
> indicates no closure). In this manner authors of XHTML and HTML documents
> are equally satisfied in not having any errors or extraneous warnings.
> Timothy Stone had reported this issue and classified it as a bug here:
> http://www.stripesframework.org/jira/browse/STS-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11931#action_11931
> The issue was rightly closed as "Not a bug" as most of the discussion was
> based on a non-w3c validator which yielded results that considered the
> validation unsuccessful which is not the case with the w3c validator (not to
> mention that it is irrelevant whether or not XHTML is considered dead or we
> should align to HTML 5 - etc...).
> As such this issue report is a re-statement of the above closed issue
> reported as an improvement and setting the stage for patch to be attached.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
This SF.net Dev2Dev email is sponsored by:
Show off your parallel programming skills.
Enter the Intel(R) Threading Challenge 2010.
http://p.sf.net/sfu/intel-thread-sfd
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development
