Stripes fails to remove values from a ThreadLocal variable in StripesFilter,
Tomcat says
----------------------------------------------------------------------------------------
Key: STS-782
URL: http://www.stripesframework.org/jira/browse/STS-782
Project: Stripes
Issue Type: Bug
Components: Context Management
Affects Versions: Release 1.5.4, Release 1.5.3, Release 1.5.2, Release
1.5.1, Release 1.5
Environment: Tested on Debian+Tomcat6, FreeBSD+Tomcat6, Mac+Tomcat6
Reporter: Roger de la Fuente
Priority: Minor
When undeploying a web-app which is using the Stripes Framework, Tomcat
complains about a ThreadLocal variable not being clean, which would cause a
memory leak. The exact error message is:
The web application [] created a ThreadLocal with key of type [null] (value
[net.sourceforge.stripes.controller.stripesfilte...@68de59f0]) and a value of
type [java.lang.Boolean] (value [true]) but failed to remove it when the web
application was stopped. This is very likely to create a memory leak.
And in fact, it does create a memory leak, since reloading the webapp few times
brings an OutOfMemoryError to the log.
I had a look at StripesFilter source code, and I coded a quick patch to fix
this. It is working now, no memory leak. I could send you the patch file if you
want to, but I just had to add one line to StripesFilter.java
Here it is:
--- src/net/sourceforge/stripes/controller/StripesFilter.java (revision: 1343)
+++ src/net/sourceforge/stripes/controller/StripesFilter.java (working copy)
@@ -257,6 +257,7 @@
// Once the request is processed, take the Configuration back
out of thread local
StripesFilter.configurationStash.remove();
+ StripesFilter.initialInvocation.remove();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Centralized Desktop Delivery: Dell and VMware Reference Architecture
Simplifying enterprise desktop deployment and management using
Dell EqualLogic storage and VMware View: A highly scalable, end-to-end
client virtualization framework. Read more!
http://p.sf.net/sfu/dell-eql-dev2dev
_______________________________________________
Stripes-development mailing list
Stripes-development@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/stripes-development
