[ 
http://www.stripesframework.org/jira/browse/STS-751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ben Gunter updated STS-751:
---------------------------

    Attachment: stripes_html_mode-1.5.5_3.patch

Timothy, I've attached a new patch that's basically just a trimmed-down version 
of your latest one. I renamed HtmlOptionsTag to PageOptionsTag so that we can 
implement non-HTML-specific options in the future using the same tag. I removed 
all the changes to the configuration interfaces and classes; PageOptionsTag 
just gets the property directly instead of relying on a method in 
Configuration. And I added a method to HtmlTagSupport that makes much of the 
code in your patch more concise.

If there are no objections, I'll commit this patch today.

> Add support ala Struts to generate HTML or XHTML compliant close tags
> ---------------------------------------------------------------------
>
>                 Key: STS-751
>                 URL: http://www.stripesframework.org/jira/browse/STS-751
>             Project: Stripes
>          Issue Type: Improvement
>          Components: Tag Library
>    Affects Versions: Release 1.5
>         Environment: No specific OS required;  no specific Java version 
> required;  etc...
>            Reporter: Nikolaos
>            Priority: Minor
>             Fix For: Release 1.5.5
>
>         Attachments: stripes-html-config.tgz, stripes-html4-input-0.1.jar, 
> stripes-xhtml-patch.tar.gz, stripes-xhtml-patches.tar.gz, 
> stripes_html_mode-1.5.5_1.patch, stripes_html_mode-1.5.5_2.patch, 
> stripes_html_mode-1.5.5_3.patch
>
>
> HTML and XHTML documents have some key differences.
> For example - if we consider the <input> tag:
> - In HTML, the <input> tag has no end tag   e.g. <input name="website.url" 
> type="text" size="30">
> - In XHTML, the <input> tag must be properly closed, like this <input />   
> e.g. <input name="website.url" type="text" size="30" />
> Stripes 1.5.x however does not have a mechanism to discern whether or not to 
> properly close tags or not and as such takes the safer approach which is to 
> explicitly close tags as it results in valid XHTML and is not an error for 
> HTML but results in a warning when validating HTML documents.  Although the 
> latter is not a critical issue it does result in needless or unnecessary 
> complaints when validating and as such is an annoyance albeit minor.
> Struts since 1.x has solved this issue quite easily by allowing the inclusion 
> of the xhtml="true" attribute to mark that closure is required (false 
> indicates no closure).  In this manner authors of XHTML and HTML documents 
> are equally satisfied in not having any errors or extraneous warnings.
> Timothy Stone had reported this issue and classified it as a bug here:
> http://www.stripesframework.org/jira/browse/STS-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=11931#action_11931
> The issue was rightly closed as "Not a bug" as most of the discussion was 
> based on a non-w3c validator which yielded results that considered the 
> validation unsuccessful which is not the case with the w3c validator (not to 
> mention that it is irrelevant whether or not XHTML is considered dead or we 
> should align to HTML 5 - etc...).  
> As such this issue report is a re-statement of the above closed issue 
> reported as an improvement and setting the stage for patch to be attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://www.stripesframework.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Increase Visibility of Your 3D Game App & Earn a Chance To Win $500!
Tap into the largest installed PC base & get more eyes on your game by
optimizing for Intel(R) Graphics Technology. Get started today with the
Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs.
http://p.sf.net/sfu/intelisp-dev2dev
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to