[ 
http://www.stripesframework.org/jira/browse/STS-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12261#comment-12261
 ] 

Remi VANKEISBELCK commented on STS-342:
---------------------------------------

Hi Richard,

Just reviewed your patch. Seems good, but I think there could be a better way 
to do this, that doesn't force implementors to code the terminate method.

I think that you can do better by introducing a new interface and check if it's 
implemented by the component(s) before calling it :

interface Disposable {
  dispose();
}

class MyComponent implements ConfigurableComponent, Disposable {
...
}

See what I mean ? This is, I think, good use of interfaces, and it won't break 
client code. 

Cheers

Remi

> proposal: terminate for ConfigurableComponent
> ---------------------------------------------
>
>                 Key: STS-342
>                 URL: http://www.stripesframework.org/jira/browse/STS-342
>             Project: Stripes
>          Issue Type: New Feature
>         Environment: any
>            Reporter: Matteo Anselmi
>             Fix For: Release 1.6
>
>         Attachments: STS-342.patch
>
>
> This proposal consists in defining a new method in ConfigurableComponent 
> interface.
> this method would be called once the application server perform a clean 
> shotdown.
> In a terminate method  would be possible to commit several data uncommitted.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload 
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve 
application availability and disaster protection. Learn more about boosting 
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to