[ 
http://www.stripesframework.org/jira/browse/STS-460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770#comment-12770
 ] 

Mike Baliel commented on STS-460:
---------------------------------

Stripes is great, but i'm having the exact same issue as described by Tim Burt. 
 There is certainly a work around for this so it is not a major issue, but 
IMHO, empty Strings should be treated as "Empty Strings".

> Empty form text fields give null String values
> ----------------------------------------------
>
>                 Key: STS-460
>                 URL: http://www.stripesframework.org/jira/browse/STS-460
>             Project: Stripes
>          Issue Type: Improvement
>          Components: ActionBean Dispatching
>    Affects Versions: Release 1.4.3
>         Environment: Windows/Linux, Tomcat 5.5.25
>            Reporter: Phil Sladen
>            Assignee: Tim Fennell
>
> I can understand that empty form fields give rise to empty objects when there 
> is a converter involved and invalid input, but it seems a bit OTT to also 
> treat Strings the same way. Although String is not a native type, it is 
> treated as such in some respects in the language, and I think Stripes should 
> do the same by default. Otherwise, code is going to be littered with checks 
> for null or be forced to use something like StringUtils. I would however 
> expect the String to be left unaltered, and possibly null, if the 
> corresponding parameter is not provided in the request. I could then choose 
> whether such extra checks are warranted for Strings as well as other objects.
> Instead, I found the most convenient way around the issue was to provide my 
> own PropertyBinder:
> public class MyPropertyBinder extends DefaultActionBeanPropertyBinder {
>         protected void bindNullValue(ActionBean bean, String property, Class 
> type)
>                         throws ExpressionException {
>                 if (type == String.class) {
>                         BeanUtil.setPropertyValue(property, bean, new 
> String());
>                 }
>                 else {
>                         super.bindNullValue(bean, property, type);
>                 }
>         }
> }
> All credit due to Stripes extensibility, but I don't think I should have to 
> do this.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to