AnnotatedClassActionResolver Creates An Exception, Logs The Exception, Then 
Throws The Exception...
---------------------------------------------------------------------------------------------------

                 Key: STS-911
                 URL: http://www.stripesframework.org/jira/browse/STS-911
             Project: Stripes
          Issue Type: Improvement
          Components: ActionBean Dispatching
    Affects Versions: Release 1.5.7
            Reporter: Dan Nelson


I think that the following {{log.error(...)}} statement should be removed:
{code:java}
// from: 
net.sourceforge.stripes.controller.AnnotatedClassActionResolver#getActionBean
// ...
}
catch (Exception e) {
    StripesServletException sse = new StripesServletException(
        "Could not create instance of ActionBean type [" + beanClass.getName() 
+ "].", e);
    log.error(sse);
    throw sse;
}
// ...
{code}

The logging of the newly created {{StripesServletException}} is excessive.  The 
reason I bring it up is because I use Guice injection everywhere...and when a 
{{ProvisionException}} is thrown I can end up with thousands of lines of logged 
stacktrace that I can only control by turning off 
{{AnnotatedClassActionResolver}} logging (via log4j.xml or logback.xml).

Any chance we can get rid of this?  What purpose can that log message serve?

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
Stripes-development mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/stripes-development

Reply via email to