craigmcc 01/01/22 19:35:53
Modified: src/share/org/apache/struts/digester CallMethodRule.java
Digester.java SetNextRule.java SetTopRule.java
Log:
Document an already existing restriction on "paramType" and "paramTypes"
arguments used within the Digester package. If the method you ultimately
call has a parameter of a Java primitive type, you must use the
corresponding Java wrapper class (such as "java.lang.Boolean" for a
"boolean" parameter) instead.
PR: BugRat Bug Report #692
Submitted by: Elod Horvath <[EMAIL PROTECTED]>
Revision Changes Path
1.6 +7 -4
jakarta-struts/src/share/org/apache/struts/digester/CallMethodRule.java
Index: CallMethodRule.java
===================================================================
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/digester/CallMethodRule.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- CallMethodRule.java 2001/01/07 22:39:06 1.5
+++ CallMethodRule.java 2001/01/23 03:35:52 1.6
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/digester/CallMethodRule.java,v
1.5 2001/01/07 22:39:06 craigmcc Exp $
- * $Revision: 1.5 $
- * $Date: 2001/01/07 22:39:06 $
+ * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/digester/CallMethodRule.java,v
1.6 2001/01/23 03:35:52 craigmcc Exp $
+ * $Revision: 1.6 $
+ * $Date: 2001/01/23 03:35:52 $
*
* ====================================================================
*
@@ -75,7 +75,7 @@
* element.
*
* @author Craig McClanahan
- * @version $Revision: 1.5 $ $Date: 2001/01/07 22:39:06 $
+ * @version $Revision: 1.6 $ $Date: 2001/01/23 03:35:52 $
*/
public final class CallMethodRule extends Rule {
@@ -109,6 +109,9 @@
* @param paramCount The number of parameters to collect, or
* zero for a single argument from the body of ths element
* @param paramTypes The Java class names of the arguments
+ * (if you wish to use a primitive type, specify the corresonding
+ * Java wrapper class instead, such as <code>java.lang.Boolean</code>
+ * for a <code>boolean</code> parameter)
*/
public CallMethodRule(Digester digester, String methodName,
int paramCount, String paramTypes[]) {
1.14 +13 -4
jakarta-struts/src/share/org/apache/struts/digester/Digester.java
Index: Digester.java
===================================================================
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/digester/Digester.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- Digester.java 2001/01/02 23:40:18 1.13
+++ Digester.java 2001/01/23 03:35:52 1.14
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/digester/Digester.java,v 1.13
2001/01/02 23:40:18 craigmcc Exp $
- * $Revision: 1.13 $
- * $Date: 2001/01/02 23:40:18 $
+ * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/digester/Digester.java,v 1.14
2001/01/23 03:35:52 craigmcc Exp $
+ * $Revision: 1.14 $
+ * $Date: 2001/01/23 03:35:52 $
*
* ====================================================================
*
@@ -102,7 +102,7 @@
* even from the same thread.</p>
*
* @author Craig McClanahan
- * @version $Revision: 1.13 $ $Date: 2001/01/02 23:40:18 $
+ * @version $Revision: 1.14 $ $Date: 2001/01/23 03:35:52 $
*/
public final class Digester extends HandlerBase {
@@ -800,6 +800,9 @@
* for a single parameter from the body of this element)
* @param paramTypes Set of Java class names for the types
* of the expected parameters
+ * (if you wish to use a primitive type, specify the corresonding
+ * Java wrapper class instead, such as <code>java.lang.Boolean</code>
+ * for a <code>boolean</code> parameter)
*/
public void addCallMethod(String pattern, String methodName,
int paramCount, String paramTypes[]) {
@@ -895,6 +898,9 @@
* @param pattern Element matching pattern
* @param methodName Method name to call on the parent element
* @param paramType Java class name of the expected parameter type
+ * (if you wish to use a primitive type, specify the corresonding
+ * Java wrapper class instead, such as <code>java.lang.Boolean</code>
+ * for a <code>boolean</code> parameter)
*/
public void addSetNext(String pattern, String methodName,
String paramType) {
@@ -953,6 +959,9 @@
* @param pattern Element matching pattern
* @param methodName Method name to call on the parent element
* @param paramType Java class name of the expected parameter type
+ * (if you wish to use a primitive type, specify the corresonding
+ * Java wrapper class instead, such as <code>java.lang.Boolean</code>
+ * for a <code>boolean</code> parameter)
*/
public void addSetTop(String pattern, String methodName,
String paramType) {
1.3 +7 -4
jakarta-struts/src/share/org/apache/struts/digester/SetNextRule.java
Index: SetNextRule.java
===================================================================
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/digester/SetNextRule.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- SetNextRule.java 2000/08/01 20:03:29 1.2
+++ SetNextRule.java 2001/01/23 03:35:52 1.3
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/digester/SetNextRule.java,v 1.2
2000/08/01 20:03:29 craigmcc Exp $
- * $Revision: 1.2 $
- * $Date: 2000/08/01 20:03:29 $
+ * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/digester/SetNextRule.java,v 1.3
2001/01/23 03:35:52 craigmcc Exp $
+ * $Revision: 1.3 $
+ * $Date: 2001/01/23 03:35:52 $
*
* ====================================================================
*
@@ -73,7 +73,7 @@
* commonly used to establish parent-child relationships.
*
* @author Craig McClanahan
- * @version $Revision: 1.2 $ $Date: 2000/08/01 20:03:29 $
+ * @version $Revision: 1.3 $ $Date: 2001/01/23 03:35:52 $
*/
public final class SetNextRule extends Rule {
@@ -103,6 +103,9 @@
* @param digester The associated Digester
* @param methodName Method name of the parent method to call
* @param paramType Java class of the parent method's argument
+ * (if you wish to use a primitive type, specify the corresonding
+ * Java wrapper class instead, such as <code>java.lang.Boolean</code>
+ * for a <code>boolean</code> parameter)
*/
public SetNextRule(Digester digester, String methodName,
String paramType) {
1.3 +7 -4
jakarta-struts/src/share/org/apache/struts/digester/SetTopRule.java
Index: SetTopRule.java
===================================================================
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/digester/SetTopRule.java,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- SetTopRule.java 2000/08/01 20:03:29 1.2
+++ SetTopRule.java 2001/01/23 03:35:52 1.3
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/digester/SetTopRule.java,v 1.2
2000/08/01 20:03:29 craigmcc Exp $
- * $Revision: 1.2 $
- * $Date: 2000/08/01 20:03:29 $
+ * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/digester/SetTopRule.java,v 1.3
2001/01/23 03:35:52 craigmcc Exp $
+ * $Revision: 1.3 $
+ * $Date: 2001/01/23 03:35:52 $
*
* ====================================================================
*
@@ -72,7 +72,7 @@
* object, passing the (top-1) (child) object as an argument.
*
* @author Craig McClanahan
- * @version $Revision: 1.2 $ $Date: 2000/08/01 20:03:29 $
+ * @version $Revision: 1.3 $ $Date: 2001/01/23 03:35:52 $
*/
public final class SetTopRule extends Rule {
@@ -102,6 +102,9 @@
* @param digester The associated Digester
* @param methodName Method name of the parent method to call
* @param paramType Java class of the parent method's argument
+ * (if you wish to use a primitive type, specify the corresonding
+ * Java wrapper class instead, such as <code>java.lang.Boolean</code>
+ * for a <code>boolean</code> parameter)
*/
public SetTopRule(Digester digester, String methodName,
String argument) {
