craigmcc 01/06/09 20:51:42
Modified: src/share/org/apache/struts/taglib/html Tag:
STRUTS_1_0_BRANCH BaseHandlerTag.java
CheckboxTag.java MultiboxTag.java OptionTag.java
OptionsTag.java RadioTag.java SelectTag.java
Log:
Correctly implement the "boolean attributes" according to the rules in
Section 3.3.4 of the HTML 4.01 specification. Instead of something like
multiple="true"
we must actually generate a value equal to the name of the attribute:
multiple="multiple"
PR: 1982
Submitted by: Howard Moore <[EMAIL PROTECTED]>
Revision Changes Path
No revision
No revision
1.3.2.2 +6 -6
jakarta-struts/src/share/org/apache/struts/taglib/html/BaseHandlerTag.java
Index: BaseHandlerTag.java
===================================================================
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/BaseHandlerTag.java,v
retrieving revision 1.3.2.1
retrieving revision 1.3.2.2
diff -u -r1.3.2.1 -r1.3.2.2
--- BaseHandlerTag.java 2001/06/01 20:39:42 1.3.2.1
+++ BaseHandlerTag.java 2001/06/10 03:51:40 1.3.2.2
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/BaseHandlerTag.java,v
1.3.2.1 2001/06/01 20:39:42 craigmcc Exp $
- * $Revision: 1.3.2.1 $
- * $Date: 2001/06/01 20:39:42 $
+ * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/BaseHandlerTag.java,v
1.3.2.2 2001/06/10 03:51:40 craigmcc Exp $
+ * $Revision: 1.3.2.2 $
+ * $Date: 2001/06/10 03:51:40 $
*
* ====================================================================
*
@@ -71,7 +71,7 @@
* appropriate implementations of these.
*
* @author Don Clasen
- * @version $Revision: 1.3.2.1 $ $Date: 2001/06/01 20:39:42 $
+ * @version $Revision: 1.3.2.2 $ $Date: 2001/06/10 03:51:40 $
*/
public abstract class BaseHandlerTag extends BodyTagSupport {
@@ -580,11 +580,11 @@
}
if (disabled) {
- handlers.append(" disabled=\"true\"");
+ handlers.append(" disabled=\"disabled\"");
}
if (readonly) {
- handlers.append(" readonly=\"true\"");
+ handlers.append(" readonly=\"readonly\"");
}
}
1.4.2.2 +5 -5
jakarta-struts/src/share/org/apache/struts/taglib/html/CheckboxTag.java
Index: CheckboxTag.java
===================================================================
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/CheckboxTag.java,v
retrieving revision 1.4.2.1
retrieving revision 1.4.2.2
diff -u -r1.4.2.1 -r1.4.2.2
--- CheckboxTag.java 2001/06/01 20:39:43 1.4.2.1
+++ CheckboxTag.java 2001/06/10 03:51:40 1.4.2.2
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/CheckboxTag.java,v
1.4.2.1 2001/06/01 20:39:43 craigmcc Exp $
- * $Revision: 1.4.2.1 $
- * $Date: 2001/06/01 20:39:43 $
+ * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/CheckboxTag.java,v
1.4.2.2 2001/06/10 03:51:40 craigmcc Exp $
+ * $Revision: 1.4.2.2 $
+ * $Date: 2001/06/10 03:51:40 $
*
* ====================================================================
*
@@ -76,7 +76,7 @@
* Tag for input fields of type "checkbox".
*
* @author Craig R. McClanahan
- * @version $Revision: 1.4.2.1 $ $Date: 2001/06/01 20:39:43 $
+ * @version $Revision: 1.4.2.2 $ $Date: 2001/06/10 03:51:40 $
*/
public class CheckboxTag extends BaseHandlerTag {
@@ -212,7 +212,7 @@
if (checked.equalsIgnoreCase("true")
|| checked.equalsIgnoreCase("yes")
|| checked.equalsIgnoreCase("on"))
- results.append(" checked=\"true\"");
+ results.append(" checked=\"checked\"");
results.append(prepareEventHandlers());
results.append(prepareStyles());
results.append(">");
1.6.2.2 +5 -5
jakarta-struts/src/share/org/apache/struts/taglib/html/MultiboxTag.java
Index: MultiboxTag.java
===================================================================
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/MultiboxTag.java,v
retrieving revision 1.6.2.1
retrieving revision 1.6.2.2
diff -u -r1.6.2.1 -r1.6.2.2
--- MultiboxTag.java 2001/06/01 20:39:43 1.6.2.1
+++ MultiboxTag.java 2001/06/10 03:51:41 1.6.2.2
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/MultiboxTag.java,v
1.6.2.1 2001/06/01 20:39:43 craigmcc Exp $
- * $Revision: 1.6.2.1 $
- * $Date: 2001/06/01 20:39:43 $
+ * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/MultiboxTag.java,v
1.6.2.2 2001/06/10 03:51:41 craigmcc Exp $
+ * $Revision: 1.6.2.2 $
+ * $Date: 2001/06/10 03:51:41 $
*
* ====================================================================
*
@@ -83,7 +83,7 @@
*
* @author Ralph Schaer
* @author Craig R. McClanahan
- * @version $Revision: 1.6.2.1 $ $Date: 2001/06/01 20:39:43 $
+ * @version $Revision: 1.6.2.2 $ $Date: 2001/06/10 03:51:41 $
*/
public class MultiboxTag extends BaseHandlerTag {
@@ -273,7 +273,7 @@
}
for (int i = 0; i < values.length; i++) {
if (value.equals(values[i])) {
- results.append(" checked=\"true\"");
+ results.append(" checked=\"checked\"");
break;
}
}
1.6.2.2 +6 -6
jakarta-struts/src/share/org/apache/struts/taglib/html/OptionTag.java
Index: OptionTag.java
===================================================================
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/OptionTag.java,v
retrieving revision 1.6.2.1
retrieving revision 1.6.2.2
diff -u -r1.6.2.1 -r1.6.2.2
--- OptionTag.java 2001/06/01 20:39:43 1.6.2.1
+++ OptionTag.java 2001/06/10 03:51:41 1.6.2.2
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/OptionTag.java,v
1.6.2.1 2001/06/01 20:39:43 craigmcc Exp $
- * $Revision: 1.6.2.1 $
- * $Date: 2001/06/01 20:39:43 $
+ * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/OptionTag.java,v
1.6.2.2 2001/06/10 03:51:41 craigmcc Exp $
+ * $Revision: 1.6.2.2 $
+ * $Date: 2001/06/10 03:51:41 $
*
* ====================================================================
*
@@ -82,7 +82,7 @@
* the server if this option is selected.
*
* @author Craig R. McClanahan
- * @version $Revision: 1.6.2.1 $ $Date: 2001/06/01 20:39:43 $
+ * @version $Revision: 1.6.2.2 $ $Date: 2001/06/10 03:51:41 $
*/
public class OptionTag extends BodyTagSupport {
@@ -248,9 +248,9 @@
results.append(value);
results.append("\"");
if (disabled)
- results.append(" disabled=\"true\"");
+ results.append(" disabled=\"disabled\"");
if (selectTag.isMatched(value))
- results.append(" selected=\"true\"");
+ results.append(" selected=\"selected\"");
results.append(">");
String text = text();
if (text == null)
1.7.2.4 +1 -1
jakarta-struts/src/share/org/apache/struts/taglib/html/OptionsTag.java
Index: OptionsTag.java
===================================================================
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/OptionsTag.java,v
retrieving revision 1.7.2.3
retrieving revision 1.7.2.4
diff -u -r1.7.2.3 -r1.7.2.4
--- OptionsTag.java 2001/06/01 20:39:43 1.7.2.3
+++ OptionsTag.java 2001/06/10 03:51:41 1.7.2.4
@@ -314,7 +314,7 @@
sb.append(value);
sb.append("\"");
if (matched)
- sb.append(" selected=\"true\"");
+ sb.append(" selected=\"selected\"");
sb.append(">");
sb.append(ResponseUtils.filter(label));
sb.append("</option>\r\n");
1.3.2.2 +5 -5
jakarta-struts/src/share/org/apache/struts/taglib/html/RadioTag.java
Index: RadioTag.java
===================================================================
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/RadioTag.java,v
retrieving revision 1.3.2.1
retrieving revision 1.3.2.2
diff -u -r1.3.2.1 -r1.3.2.2
--- RadioTag.java 2001/06/01 20:42:28 1.3.2.1
+++ RadioTag.java 2001/06/10 03:51:41 1.3.2.2
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/RadioTag.java,v
1.3.2.1 2001/06/01 20:42:28 craigmcc Exp $
- * $Revision: 1.3.2.1 $
- * $Date: 2001/06/01 20:42:28 $
+ * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/RadioTag.java,v
1.3.2.2 2001/06/10 03:51:41 craigmcc Exp $
+ * $Revision: 1.3.2.2 $
+ * $Date: 2001/06/10 03:51:41 $
*
* ====================================================================
*
@@ -77,7 +77,7 @@
* Tag for input fields of type "radio".
*
* @author Craig R. McClanahan
- * @version $Revision: 1.3.2.1 $ $Date: 2001/06/01 20:42:28 $
+ * @version $Revision: 1.3.2.2 $ $Date: 2001/06/10 03:51:41 $
*/
public class RadioTag extends BaseHandlerTag {
@@ -224,7 +224,7 @@
results.append(this.value);
results.append("\"");
if (value.equals(current))
- results.append(" checked=\"true\"");
+ results.append(" checked=\"checked\"");
results.append(prepareEventHandlers());
results.append(prepareStyles());
results.append(">");
1.3.2.2 +5 -5
jakarta-struts/src/share/org/apache/struts/taglib/html/SelectTag.java
Index: SelectTag.java
===================================================================
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/SelectTag.java,v
retrieving revision 1.3.2.1
retrieving revision 1.3.2.2
diff -u -r1.3.2.1 -r1.3.2.2
--- SelectTag.java 2001/06/01 20:39:43 1.3.2.1
+++ SelectTag.java 2001/06/10 03:51:41 1.3.2.2
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/SelectTag.java,v
1.3.2.1 2001/06/01 20:39:43 craigmcc Exp $
- * $Revision: 1.3.2.1 $
- * $Date: 2001/06/01 20:39:43 $
+ * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/SelectTag.java,v
1.3.2.2 2001/06/10 03:51:41 craigmcc Exp $
+ * $Revision: 1.3.2.2 $
+ * $Date: 2001/06/10 03:51:41 $
*
* ====================================================================
*
@@ -81,7 +81,7 @@
* inside a form tag.
*
* @author Craig R. McClanahan
- * @version $Revision: 1.3.2.1 $ $Date: 2001/06/01 20:39:43 $
+ * @version $Revision: 1.3.2.2 $ $Date: 2001/06/10 03:51:41 $
*/
public class SelectTag extends BaseHandlerTag {
@@ -251,7 +251,7 @@
results.append("\"");
}
if (multiple != null) {
- results.append(" multiple=\"true\"");
+ results.append(" multiple=\"multiple\"");
}
if (size != null) {
results.append(" size=\"");
