craigmcc 2002/10/12 18:30:00
Modified: src/share/org/apache/struts/util GenericDataSource.java
Log:
org.apache.commons.dbcp.BasicDataSource (which is wrapped by GenericDataSource)
does not implement getLoginTimeout() or setLoginTimeout(), so swallow them.
However, log a warning-level message so that the user might get a clue why
these calls do not seem to do anything useful.
PR: Bugzilla #12599
Submitted by: dgraham1980 at hotmail.com
Revision Changes Path
1.15 +9 -6
jakarta-struts/src/share/org/apache/struts/util/GenericDataSource.java
Index: GenericDataSource.java
===================================================================
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/util/GenericDataSource.java,v
retrieving revision 1.14
retrieving revision 1.15
diff -u -r1.14 -r1.15
--- GenericDataSource.java 20 Jul 2002 17:41:17 -0000 1.14
+++ GenericDataSource.java 13 Oct 2002 01:30:00 -0000 1.15
@@ -301,7 +301,9 @@
*/
public int getLoginTimeout() throws SQLException {
- return (createDataSource().getLoginTimeout());
+ // return (createDataSource().getLoginTimeout());
+ log.warn("BasicDataSource does not support getLoginTimeout, returning 0");
+ return (0);
}
@@ -328,7 +330,8 @@
*/
public void setLoginTimeout(int loginTimeout) throws SQLException {
- createDataSource().setLoginTimeout(loginTimeout);
+ // createDataSource().setLoginTimeout(loginTimeout);
+ log.warn("BasicDataSource does not support setLoginTimeout, ignoring");
}
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
