An additional strategy to consider is to follow the pattern that I used
with GenericDataSource (when we switched to using commons-dbcp under the
covers) -- make the Struts-specific classes in o.a.s.util be just wrappers
around commons-resources, instead of forcing nearly every class to change.
This also protects application classes that are using the o.a.s.util APIs
already.
Doing this lets us migrate to commons-resources at a pace that makes sense
(including deferring things to after 1.1).
Craig
On Thu, 17 Oct 2002, Joe Germuska wrote:
> Date: Thu, 17 Oct 2002 12:31:32 -0500
> From: Joe Germuska <[EMAIL PROTECTED]>
> Reply-To: Struts Developers List <[EMAIL PROTECTED]>
> To: Struts Developers List <[EMAIL PROTECTED]>
> Subject: Re: Validator 1.0 Release and bug 10868
>
> At 12:58 PM -0400 2002/10/17, Robert Leland wrote:
> >Joe Germuska wrote:
> >> The problem being that Struts hasn't really switched over to
> >> commons-resources yet. That would end up touching almost every
> >> class! Who wants to take that on when the masses are clamoring at
> >> the gates for a 1.1 final release!
> >
> >If the API's are very similar then I could do it, with IntelliJ with a few
> >mouse clicks.
> >
> >We could always create an Interface in commons-resources and have
> >the struts implement that or have the struts classes extend the
> >commons-resources, that would limit the amount of code touched
> >for this release, then we could do a full conversion piece-by-piece later.
>
> I don't think it's going to be that easy, although I think there
> might be a way to do it incrementally. First, Struts uses its own
> MessageResources class in two ways -- first for supporting error
> reporting for itself (as in "org.apache.struts.util.LocalStrings"),
> and then also for user provided messages.
>
> Perhaps for starters, we could leave the "internal" use unchanged and
> just look at how user-provided resources are dealt with. I think
> access to the user defined bundles is mostly in just two classes
> (Action and RequestUtils), but the API in those two classes makes
> some assumptions that don't map too easily into commons-resources.
>
> Given that three commons-resources committers are active or emeritus
> Struts committers, maybe we should see if any of them have developed
> a plan for this.
>
> Joe
>
> --
> --
> * Joe Germuska { [EMAIL PROTECTED] }
> "It's pitiful, sometimes, if they've got it bad. Their eyes get
> glazed, they go white, their hands tremble.... As I watch them I
> often feel that a dope peddler is a gentleman compared with the man
> who sells records."
> --Sam Goody, 1956
>
> --
> To unsubscribe, e-mail: <mailto:struts-dev-unsubscribe@;jakarta.apache.org>
> For additional commands, e-mail: <mailto:struts-dev-help@;jakarta.apache.org>
>
>
--
To unsubscribe, e-mail: <mailto:struts-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:struts-dev-help@;jakarta.apache.org>
