Re: Replacing Action.* with Globals. README *

Erik Hatcher Wed, 13 Nov 2002 13:14:59 -0800

Just be sure to be seated if you ever decide to give IDEA IntelliJ a try if you get that excited about measley little import cleanup :))

Don't get me wrong, Eclipse is cool and the price is nice. But IntelliJ.... thats where its at :)

James Mitchell wrote:

I must admit.  Since the hoopla a few weeks ago about Eclipse this and
Eclipse that......I decided to download it and try it out......WOW!!!!!!!  I
was a big NetBeans advocate, but now I'm hooked on Eclipse and I haven't
looked back since.


Can you believe how it resolves the import statements?  Hell, you can just
delete them all, then select 'Organize Imports' and it will rip through the
classpath and group and fix all imports to what they should have
been........come on.....you gotta love that.

My personal favorite....Hierarchy view, just F4 on a class, package, or
source folder and you get an instant overview (inheritance hieratical
treeview) from java.lang.Object to lowest subclass.....who needs a diagram
when you've got this?


James Mitchell
Software Engineer/Struts Evangelist
http://www.open-tools.org

"If you were plowing a field, which would you rather use? Two strong oxen or
1024 chickens?"
- Seymour Cray (1925-1996), father of supercomputing

-----Original Message-----
From: David Graham [mailto:dgraham1980@;hotmail.com]
Sent: Tuesday, November 12, 2002 6:43 PM
To: [EMAIL PROTECTED]
Subject: RE: Replacing Action.* with Globals.******** README *********


+1 on separating formatting from code changes.  In my defense, several of
the files had import javax.servlet.* which violates the current import
practice (a practice I disagree with but follow nonetheless).
Also, some of
the imports were no longer needed and Eclipse removed them.  The
tiles code
in particular did not follow the java standard coding guidelines so I
formatted those as well.

I apologize for the inconvenience; from now on, I'll commit appropriate
formatting changes separately.

Dave

From: "James Mitchell" <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: "Struts Developers List" <[EMAIL PROTECTED]>
Subject: RE: Replacing Action.* with Globals.******** README *********
Date: Tue, 12 Nov 2002 16:06:22 -0500

Since we are all bashing David (LOL...just kidding), may I make one more
suggestion.

Can we all agree to separate code changes with format changes?

I usually check every commit to see if it impacts something I might be
working on (bug fix or personal dev) and as I was browsing my mail this
morning, I found that reading through a couple of "recent

commits " <wink/>

was giving me a migraine.  Finding the actual code changes was

impossible.

In fact, we probably should not be using our IDE's 'reformat' features
unless the current page formatting is complete crap.  If we each reformat
every time we open and change a file.  We will see battles

emerging between

JBuilder, NetBeans, Eclipse, and others.

If that sounds feasible, I would also recommend to those of us just using
text editors to turn off the 'trim trailing spaces' when saving.  This
causes just as much of a headache.

Your thoughts?



James Mitchell
Software Engineer/Struts Evangelist
http://www.open-tools.org

"If you were plowing a field, which would you rather use? Two

strong oxen

or
1024 chickens?"
- Seymour Cray (1925-1996), father of supercomputing

-----Original Message-----
From: David Graham [mailto:dgraham1980@;hotmail.com]
Sent: Tuesday, November 12, 2002 12:10 PM
To: [EMAIL PROTECTED]
Subject: RE: Replacing Action.* with Globals.*

You are right.  I didn't wait long enough because I was making
other changes
and didn't want to get confused about which ones to commit.

David

From: "Martin Cooper" <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: "'Struts Developers List'" <[EMAIL PROTECTED]>
Subject: RE: Replacing Action.* with Globals.*
Date: Tue, 12 Nov 2002 08:49:49 -0800

-----Original Message-----
From: David Graham [mailto:dgraham1980@;hotmail.com]
Sent: Tuesday, November 12, 2002 8:30 AM
To: [EMAIL PROTECTED]
Subject: Re: Replacing Action.* with Globals.*


I committed the updates last night because I didn't hear
anyone complain.

I don't have a problem with the changes.

I would like to point out, however, that you only waited 3 hours for
feedback. Not all of us are in the same country, let alone the same

time

zone. Cedric, for example, had no hope of responding in

time, unless he

happened to be reading Struts mail at around 3am his time (my

estimate).

Even those of us in an appropriate time zone are not all constantly
checking
mail to struts-dev.

Given your statement that you "would hate to do this and

have to back

out

the changes" (which I understand :), I would suggest that you

might want to

allow more time for people to respond before going ahead with

changes like

this. Otherwise, you do leave yourself open to having to back out the
changes.

--
Martin Cooper

David

From: Eddie Bush <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List"

<[EMAIL PROTECTED]>

To: Struts Developers List <[EMAIL PROTECTED]>
Subject: Re: Replacing Action.* with Globals.*
Date: Tue, 12 Nov 2002 09:41:04 -0600

Well, we're headed toward using Globals instead of Action

for this purpose,

so I'd think it would be highly desirable for the internal

code to use

those constants located in Globals.

... The Action constants can't go away yet (at least I

believe that's the

decision that was arrived at), but I can't see where

changing internal code

to use Global references over Action references would be a bad

thing.

David Graham wrote:

Is it ok to replace the Action constant references with

Globals constant

references in the Struts code?  I would hate to do this and

have to back

out the changes.

Thanks,
Dave


--
Eddie Bush





--
To unsubscribe, e-mail:
<mailto:struts-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail:
<mailto:struts-dev-help@;jakarta.apache.org>


_________________________________________________________________
MSN 8 helps eliminate e-mail viruses. Get 2 months FREE*.
http://join.msn.com/?page=features/virus


--
To unsubscribe, e-mail:
<mailto:struts-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail:
<mailto:struts-dev-help@;jakarta.apache.org>

--
To unsubscribe, e-mail:
<mailto:struts-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail:
<mailto:struts-dev-help@;jakarta.apache.org>


_________________________________________________________________
Add photos to your messages with MSN 8. Get 2 months FREE*.
http://join.msn.com/?page=features/featuredemail


--
To unsubscribe, e-mail:

<mailto:struts-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail:
<mailto:struts-dev-help@;jakarta.apache.org>



--
To unsubscribe, e-mail:
<mailto:struts-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail:
<mailto:struts-dev-help@;jakarta.apache.org>


_________________________________________________________________
Add photos to your e-mail with MSN 8. Get 2 months FREE*.
http://join.msn.com/?page=features/featuredemail


--
To unsubscribe, e-mail:

<mailto:struts-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:struts-dev-help@;jakarta.apache.org>



--
To unsubscribe, e-mail:   <mailto:struts-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:struts-dev-help@;jakarta.apache.org>


--
To unsubscribe, e-mail:   <mailto:struts-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:struts-dev-help@;jakarta.apache.org>

Re: Replacing Action.* with Globals.******** README *********

Reply via email to

Re: Replacing Action.* with Globals. README *