Re: [PATCH] for 13279

Mon, 03 Feb 2003 12:50:10 -0800

Please post this to the bugzilla ticket. We don't accept patches through the mailing list because they tend to get lost.

David



From: Jay <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: Struts Development <[EMAIL PROTECTED]>
Subject: [PATCH]  for 13279
Date: 03 Feb 2003 15:49:10 -0500

Cedric et.al;

Enclosed are two proposed patches for the "swallowing exception"
behavior of taglib/tiles/InsertTag.java (Bugzilla #13279).  The first,
"InsertTagNoFuncChange.txt", does what I originally suggested: merely
move the real handling of processException to a method outside of the
inner class to a protected method in InsertTag where sub-classing and
overriding the default behavior can easily be done.

The second patch ("InsertTagFuncChange.txt") does change the behavior by
only "swallowing" the exception when the log4j debug level is enabled
for the class.  If debug is not enabled, the exception will be wrapped
and "re-thrown" as the root cause of a JspException.

I think the second alternative is the better one because a default
behavior of broadcasting exceptions on the web page is not particularly
desirable.  However, I will be happy if either alternative is applied

I have provided complete javadoc comments for both alternatives that you
may change as required.

Thank you,
Jay


<< InsertTagNoFuncChange.txt >>
<< InsertTagFuncChange.txt >>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

_________________________________________________________________
The new MSN 8: advanced junk mail protection and 2 months FREE* http://join.msn.com/?page=features/junkmail


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to