LOL....now this is interesting, supposing I had picked a different locale....who knows how long this might have gone undetected.
I just changed my regional settings to France and my tests failed as well. I already see the problem and will commit the fix tonight. I forced the locale for the MessageTag tests, but forgot to do the same for WriteTag. -- James Mitchell Software Engineer/Struts Evangelist > -----Original Message----- > From: Cedric Dumoulin [mailto:[EMAIL PROTECTED] > Sent: mercredi 26 f�vrier 2003 11:09 > To: Struts Developers List > Subject: Test suites fail on localized computer > > > > Hi all, > > Today I have run the test suite test.tomcat.41, but it fail on my > computer: > > [junit] junit.framework.AssertionFailedError: > expected:<1,234> but > was:<1� 234> > [junit] at > org.apache.struts.taglib.bean.TestWriteTag.formatAndTest(TestW > riteTag.java:122) > [junit] at > org.apache.struts.taglib.bean.TestWriteTag.endWriteTagNameForm > at(TestWriteTag.java:153) > > Checking the code, it appear that we compare a localized string > returned by the server with a static string not localized ;-). This > should work well when the server is US_en, but doesn't work > with FR_fr, > and other locales. > Note that the shown returned string (<1� 234>) is not necessarily the > real returned string, because the text file used to catch the output > doesn't support well localization. > > There is other comparisons of this kind in the TestWriteTag > file, and > maybe in other files. I have try to run ant with other locale > parameters, with no success: Tomcat is always launched with > the locale > of my computer, which I can't change. > As a result, I can't run the test suites. Is there someone > who have a > simple solution, or should we change the TestWriteTag file (how?). > > cedric > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
