James Turner wrote:

It's auto-generated code, so you can talk to the ANTLR folks if you want
:-)



I was hoping for you would volunteer to take a look at the generated code when you have the chance. :-D
This would be helpful since I haven't used validwhen, and
am less motovated than someone who has a *live* site using the code. ;-)


Then how do we handle *maintaining* generated code ?
a) manually fix any bugs.
b) wait for antlr bug fixes then recreate the files.


Rob



James



-----Original Message-----
From: Rob Leland [mailto:[EMAIL PROTECTED] Sent: Sunday, July 27, 2003 1:17 AM
To: Struts Developers List
Subject: [validator - ValidWhen ] Bug or unneeded variable.



James:


The variable 'theRetToken' is assigned but never used in method nextToken() Instead _returnToken is always returned.

So it appears that theRetToken is unneeded, or this is a bug.

Also the method mWS()

on line 272:
       _ttype = Token.SKIP;
       if ( _createToken && _token==null && _ttype!=Token.SKIP ) {
        }
so the if statement will never be executed.



--
Rob Leland



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]






--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]







--
Rob Leland



Reply via email to