The one thing that the ticket doesn't say specifically is whether you are already using the patch in a working application.
If so, and it's working well for you in practice, then I'd say commit it.
But, if its experimental, then I'd say let's roll a 1.2.x GA first before playing with something this deep in the API.
The cutting point being whether you, as a Committer, have a high-degree of confidence in the code.
We should probably mark the feature "experimental" in either case, just to see what shakes out when it's presented to the Community.
-Ted.
Don Brown wrote:
I'd like to put the wildcard-matched action code from Bug #21813 (http://issues.apache.org/bugzilla/show_bug.cgi?id=21813) into Struts. When I mentioned it last, the only concern I heard raised was from Craig regarding performance penalties. As I noted in the bug description, the path isn't checked against compiled wildcards until an exact match cannot be found. Even then, it is only checked against action mappings that actually contain at least one wildcard.
Let me know if anyone has any reason I shouldn't do this or concerns I can hopefully alleviate. Thanks.
Don
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Ted Husted, Junit in Action - <http://www.manning.com/massol/>, Struts in Action - <http://husted.com/struts/book.html>, JSP Site Design - <http://www.amazon.com/exec/obidos/ISBN=1861005512>.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
