This change presents a bug!

if i do this: <logic:present name="attributes">

then logic calls: RequestUtils.lookup(xxx)

And it doesn't find that bean. So RequestUtils suddenly throws a Exception which
it didn't before. So now the present tag isn't working anymore.

Johan


----- Original Message -----
From: <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Sunday, June 10, 2001 6:13 AM
Subject: cvs commit: jakarta-struts/src/share/org/apache/struts/util RequestUtils.java


> craigmcc    01/06/09 21:13:34
>
>   Modified:    src/share/org/apache/struts/util RequestUtils.java
>   Log:
>   Port the fix for Bugzilla #2088.
>
>   Revision  Changes    Path
>   1.17      +6 -6      
>jakarta-struts/src/share/org/apache/struts/util/RequestUtils.java
>
>   Index: RequestUtils.java
>   ===================================================================
>   RCS file: 
>/home/cvs/jakarta-struts/src/share/org/apache/struts/util/RequestUtils.java,v
>   retrieving revision 1.16
>   retrieving revision 1.17
>   diff -u -r1.16 -r1.17
>   --- RequestUtils.java 2001/06/01 20:22:21 1.16
>   +++ RequestUtils.java 2001/06/10 04:13:34 1.17
>   @@ -1,7 +1,7 @@
>    /*
>   - * $Header: 
>/home/cvs/jakarta-struts/src/share/org/apache/struts/util/RequestUtils.java,v 1.16 
>2001/06/01 20:22:21 craigmcc Exp
$
>   - * $Revision: 1.16 $
>   - * $Date: 2001/06/01 20:22:21 $
>   + * $Header: 
>/home/cvs/jakarta-struts/src/share/org/apache/struts/util/RequestUtils.java,v 1.17 
>2001/06/10 04:13:34 craigmcc Exp
$
>   + * $Revision: 1.17 $
>   + * $Date: 2001/06/10 04:13:34 $
>     *
>     * ====================================================================
>     *
>   @@ -95,7 +95,7 @@
>     * in the Struts controller framework.
>     *
>     * @author Craig R. McClanahan
>   - * @version $Revision: 1.16 $ $Date: 2001/06/01 20:22:21 $
>   + * @version $Revision: 1.17 $ $Date: 2001/06/10 04:13:34 $
>     */
>
>    public class RequestUtils {
>   @@ -489,14 +489,14 @@
>
>            // Look up the requested bean, and return if requested
>            Object bean = lookup(pageContext, name, scope);
>   -        if (property == null)
>   -            return (bean);
>            if (bean == null) {
>                JspException e = new JspException
>                    (messages.getMessage("lookup.bean", name, scope));
>                saveException(pageContext, e);
>                throw e;
>            }
>   +        if (property == null)
>   +            return (bean);
>
>            // Locate and return the specified property
>            try {
>
>
>

Reply via email to