Renaud, >My company is using Struts pretty extensively, the upload module in >particular, and we've come across some pretty serious bugs that have >prompted an internal discussion about its deficiencies.
;) >I found a post to struts-dev where Mike wishes he had the time to replace >the existing upload code with O'Reilly's implementation -- or at least this >is my understanding, correct me if I'm wrong. Hmm. I think I was trying to make an implementation of struts upload that used the O'Rielly upload package. Replacing the existing upload code isn't really necessary, but fixing some bugs in the existing package is. >As my company has a business interest in getting the upload module working >perfectly, they may be willing to do the work and donate it to the Struts >project. But first I'd like to hear from you what the current status of the >Struts upload is like; is it in your opinion stable and production quality? >Is integrating the O'Reilly upload stuff in Struts a good idea? A quick link to the list of bugs for File Upload: http://nagoya.apache.org/bugzilla/buglist.cgi?bug_status=NEW&bug_status=ASSI GNED&bug_status=REOPENED&email1=&emailtype1=substring&emailassigned_to1=1&em ail2=&emailtype2=substring&emailreporter2=1&bugidtype=include&bug_id=&change din=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&product=Struts&componen t=File+Upload&short_desc=&short_desc_type=allwordssubstr&long_desc=&long_des c_type=allwordssubstr&bug_file_loc=&bug_file_loc_type=allwordssubstr&keyword s=&keywords_type=anywords&field0-0-0=noop&type0-0-0=noop&value0-0-0=&cmdtype =doit&order=%27Importance%27 There are 10 outstanding issues for file upload in Struts, some minor, some not so minor. I'm almost at the point where I can devote some time to addressing these issues, and maybe even do a partial re-write of the MultipartIterator class if necessary. It would definately be worth your time, if you're willing to work on it, to address these bugs. I'll be a bit more vigilant about email and help out as much as I can. To start you really want to look at the DiskMultipartRequestHandler and MultipartIterator class, thats where all the trouble starts. There's a few ways it could be improved, and in further emails I'd be happy about going into detail. The overall architecture of file upload is not too bad in my opinion, and doesn't need changing. Just the implementation. I bet there might be some performance issues too, which I think I'm much more capable of handling now than when I first wrote it. So, how about we do this "extreme programming" style, where we figure out what needs to be done to get stuff running as optimally as possible through email, break up the things into small tasks, and take on the tasks one by one. I'd be more than happy to make the struts upload work as well as possible, it's been bothering me for a while and I haven't had time. >Thank you for your answers, >--Renaud Thank you for helping, Mike -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
