I checked in what I've done so far. Commons Logging issues. 1. Do we want to just add console logging to the example web apps or log to a file? Are you still running the nightly build Craig? Log4J would need to be added to the properties file so it can be included in the webapps for the binary distribution. Or we can activate the console logging in the Commons Logging pacakge.
2. I left the log(msg) method in ActionServlet, ActionServletWrapper, and RequestProcessor. I deprecated the log method to the logWriter in GenericDataSource and switched the class itself to use Commons Logging. MessageResources log method logs to Commons Logging. That method was logging to System.out, but since other people are calling the other log methods and they are at least being written to a file I wasn't sure if they should be changed to Commons Logging. 3. appConfig.getServlet().getDebug() I didn't change this. I'm not sure how this fits in with adding Commons Logging. I left this as the conditional, but change the logging inside to log.debug. Files updated. src/share/org/apache/struts/action/ActionServlet.java src/share/org/apache/struts/action/RequestProcessor.java src/share/org/apache/struts/actions/DispatchAction.java src/share/org/apache/struts/upload/DiskMultipartRequestHandler.java src/share/org/apache/struts/util/GenericDataSource.java src/share/org/apache/struts/util/MessageResources.java src/share/org/apache/struts/util/MessageResourcesFactory.java src/share/org/apache/struts/util/RequestUtils.java Another sidenote is that commons-services.jar and commons-validator.jar are in the build.xml, but not in the build.properties.sample file. I was going to fix this, but I didn't want to break the nightly build. David __________________________________________________ Do You Yahoo!? Yahoo! Sports - Coverage of the 2002 Olympic Games http://sports.yahoo.com -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
