The bottom line here is that having multiple data sources and using the nightly build does not work unless you use my patch.
I'm a little surprised that this is being ignored. Here I fixed a bug listed in "Bug report for Struts" for two months now, and it hasn't gotten even as much as a comment. I can't tell if I fixed it "right" or not, but the problem is solved for my application. If we wanted to stay on the nightly build, this bug was a show stopper for my project because we *must* offer multiple data sources for each installation. Believe me, struts-dev *wants* my project on the nightly build. My company is about to go beta with this project, and that translates to more testers for Struts. Sorry if I am coming off a little harsh. I'm sure it's because you are all just so busy. But this is an open source project, and I did my best to not only identify the root cause, but even went as far as fixing it for my build anyway. Anthony -----Original Message----- From: Anthony Martin [mailto:[EMAIL PROTECTED]] Sent: Wednesday, February 27, 2002 11:15 AM To: Struts Developer's List (E-mail) Subject: Multiple DataSource As mentioned in bugzilla #6060, *part* of the reason multiple data-sources doesn't work is DataSourceConfig.addProperty() adds the KEY to the properties, when it should just assign it's member. Here's a diff on the version in CVS for Feb 27th of what I mean: Index: src/share/org/apache/struts/config/DataSourceConfig.java =================================================================== RCS file: /home/cvspublic/jakarta-struts/src/share/org/apache/struts/config/DataSource Config.java,v retrieving revision 1.4 diff -u -r1.4 DataSourceConfig.java --- src/share/org/apache/struts/config/DataSourceConfig.java 23 Feb 2002 23:53:29 -0000 1.4 +++ src/share/org/apache/struts/config/DataSourceConfig.java 27 Feb 2002 19:18:39 -0000 @@ -157,10 +157,14 @@ */ public void addProperty(String name, String value) { - if (configured) { - throw new IllegalStateException("Configuration is frozen"); - } - properties.put(name, value); + if ( name.equals("key") ) { + setKey(value) ; + } else { + if (configured) { + throw new IllegalStateException("Configuration is frozen"); + } + properties.put(name, value); + } } -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
