I'm not opposed to the Impl naming if you don't have to type it in code or configure it. The java socket classes use this convention but we're spared from seeing them. In general, I believe Impl classes shouldn't be seen by general developers.

David






From: Robert Leland <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: Struts Developers List <[EMAIL PROTECTED]>
Subject: Re: DO NOT REPLY [Bug 14054] - Rename "Application" components to "Module"
Date: Mon, 04 Nov 2002 14:27:05 -0500

Subject: Re: DO NOT REPLY [Bug 14054] - Rename "Application" components to "Module"
From: "David Graham" <[EMAIL PROTECTED]>
Date: 2002-11-04 18:04:41
[Download message RAW]

> +1 on the ModuleConfig interface (Struts needs more of these).
> I'm not sure about StandardModuleConfigImpl though. > Where will the user see this *Impl class if anywhere?
> If the user never has to write this then I suggest ModuleConfigImpl. > If they have to write it somewhere then drop the "Impl"
> part and use StandardModuleConfig or StrutsModuleConfig.


'ModuleConfigImpl' would be +1. The 'Impl' was patterened after what we do here
at my Job and also what commons-logging, commons-pool do for naming implementations
and interfaces.

If a --user-- is defined as struts-user mailing list, yes they shouldn't see the Impl classes. Neither, would
most of the Struts internal classes. I didn't want to overdesign but did want to reserve
the name 'ModuleConfig' for the general concept.


> Dave

-Rob



--
To unsubscribe, e-mail: <mailto:struts-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:struts-dev-help@;jakarta.apache.org>

_________________________________________________________________
Get faster connections -- switch to MSN Internet Access! http://resourcecenter.msn.com/access/plans/default.asp


--
To unsubscribe, e-mail: <mailto:struts-dev-unsubscribe@;jakarta.apache.org>
For additional commands, e-mail: <mailto:struts-dev-help@;jakarta.apache.org>

Reply via email to