martinc 2002/12/05 23:58:40
Modified: src/share/org/apache/struts/taglib/tiles
UseAttributeTag.java
Log:
Fix a problem with tag handler instance reuse - do not modify attribute
values from within the tag handler.
PR: 14366
Submitted by: Anand
Revision Changes Path
1.6 +8 -8
jakarta-struts/src/share/org/apache/struts/taglib/tiles/UseAttributeTag.java
Index: UseAttributeTag.java
===================================================================
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/tiles/UseAttributeTag.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- UseAttributeTag.java 16 Nov 2002 04:46:05 -0000 1.5
+++ UseAttributeTag.java 6 Dec 2002 07:58:39 -0000 1.6
@@ -211,9 +211,9 @@
public int doStartTag() throws JspException
{
// Do a local copy of id
- String id=this.id;
- if( id==null )
- id=attributeName;
+ String localId=this.id;
+ if( localId==null )
+ localId=attributeName;
ComponentContext compContext = (ComponentContext)pageContext.getAttribute(
ComponentConstants.COMPONENT_CONTEXT, pageContext.REQUEST_SCOPE);
if( compContext == null )
@@ -231,10 +231,10 @@
{
scope = TagUtils.getScope( scopeName, PageContext.PAGE_SCOPE );
if(scope!=ComponentConstants.COMPONENT_SCOPE)
- pageContext.setAttribute(id, value, scope);
+ pageContext.setAttribute(localId, value, scope);
}
else
- pageContext.setAttribute(id, value);
+ pageContext.setAttribute(localId, value);
// Continue processing this page
return SKIP_BODY;
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
