DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13279>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13279

Getting InsertTag not to swallow exceptions

[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |



------- Additional Comments From [EMAIL PROTECTED]  2002-12-12 19:37 -------
Look at the doEndTag() method of the inner TagHandler class and the 
processException() method that it calls when it catches an Exception. The 
processException() method logs the error but that doesn't qualify as handling 
the error. The exception needs to be re-thrown (maybe optionally, in order to 
be backwards compatible) so that it can be handled appropriately by the Struts 
exception handling mechanism or the Servlet specification's exception handling 
mechanism. Handling may end up being logging the error and sending the user to 
an error page but that is better than dumping the error text and possibly the 
stack trace in the middle of whatever page the tile is part of. 

The processException method isn't fully commons-log enabled either, as it does 
log.debug(msg); ex.printStackTrace(); instead of log.debug(msg,ex); 

Sorry to complain rather than patch.

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to