... but, until that time comes, I think we should repect whatever (lack of) format exists in a given source file. I know some of them look like goobledy-gook, but I just about guarantee you it looks great in someone's editor - and changing it may cause it to look like goobledy-gook to them (which could be bad, if they're usually the person to edit that file). Wouldn't it be nice if all editors treated tabs the same way? (I think that's the root problem at fault here - least that was my "best guess" based off what I recollect browsing "ugly" source files).
Hey! Here's a thought! We could make everyone "standardize" on using "ed" - and then all source files would be equally readable by all!
(Yes, that's a very sick joke!)
--
Eddie Bush
Martin Cooper wrote:
On Mon, 16 Dec 2002, Cedric Dumoulin wrote:I said that I don't want to debate on this. I know the reformated code doesn't follow the recomanded Jakarta rules code standard. But another rule is to respect any other well formated standard ;-).While I agree with respecting an original author's choices, I don't agree with having multiple sets of coding conventions in a single code base. That can only be confusing for everyone. In addition, when we move to Maven as the build system for Struts, we will have to define a single set of coding conventions for Checkstyle to work with. I'm not suggesting that we have to spend the time now to decide what our conventions are, just suggesting that we, at some point in time, need to decide on a single set of coding conventions for the entire Struts code base. -- Martin CooperFor me, the reformated code is really unreadable: I can't detect the classes and methods structures at a glance, and so it requires me some times to try to figure it out. I thing it is a waste of time ... Cedric David Graham wrote:With all due respect Cedric, that code did not follow the java standard coding guidelines so it was a candidate for reformatting. Under the Jakarta rules code must meet those guidelines unless specified differently for the project. AFAIK Struts has no specific rules so it defaults to the java standard. Following the java standard helps all developers work on the project faster and easier. DaveFrom: Cedric Dumoulin <[EMAIL PROTECTED]> Reply-To: "Struts Developers List" <[EMAIL PROTECTED]> To: Struts Developers List <[EMAIL PROTECTED]> Subject: Avoid code reformating ! Date: Mon, 16 Dec 2002 22:09:22 +0100 Hi everybody, Code formating is an ever ending debate. We, as experienced developers, all have our preferences. When there is several users as in Struts, there is a polite rule: do not reformate code of others just because they don't follow your criteria. I have discover such reformating in code that I have written. The problem is that I don't recognize the code anymore, it takes me more time to do something, and comparisons tools can't work anymore ;-( I don't want to debate about the "right" or the "best" code formating. I just ask for the respect of each others. So, for those having an automatic code formatter, please disable it when playing with struts code, and resist to the tentation ;-) Cedric
-- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
