CVS takes care of line end conversions, so yes, there is a "right" line end. The Apache repository is on a *nix box, so the line ends on that system are *nix line ends. When I check out on to a Windows box, my CVS client takes care of presenting me with Windows line ends (as long as the file is not flagged as binary), and then when I check back in, the result is changed to the *nix file, with *nix line ends.
Bad line ends in a CVS text file, as with the files you pointed out, are generally caused by bad (or incorrectly configured) CVS clients. Note that I threw this bug report over the fence to Jakarta Commons, since that is where BeanUtils lives now. It'll be fixed before Struts 1.1 Final is released, and probably much sooner. -- Martin Cooper On Wed, 8 Jan 2003, David Morris wrote: > I added a similar comment to the bugzilla site, but > it never seemed to work so I am responding here. > > I don't know if there is a "right" line end. Each > platform is different. I work in an environment where > we run Linux and Windows and run into this > frequently. Coincidentally, I posted a patch to the commons-dev list for > build.xml that included a new target that will run the fixcrlf ant task, > which sets > line ends to the line end associated with the > system running the build. If you happen to use > Eclipse, there is an option to fix CR/LF characters > on the edit drop down menu. The target I added fixes > the CR/LF and adds source to the distribution jar, > which makes debugging in Struts much easier. > > David Morris > > >>> [EMAIL PROTECTED] 01/08/03 17:30 PM >>> > > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15908 > > commons-beanutils.jar, debug info line numbers off by factor of 2 > > [EMAIL PROTECTED] changed: > > What |Removed |Added > ---------------------------------------------------------------------------- > AssignedTo|struts- |commons- > |[EMAIL PROTECTED] |[EMAIL PROTECTED] > Component|Unknown |Bean Utilities > Product|Struts |Commons > Version|1.1 Beta 3 |Nightly Builds > > > > ------- Additional Comments From [EMAIL PROTECTED] 2003-01-09 00:31 > ------- > This is indeed a line end problem, but it is not a compilation problem. > It > seems that all of the sources in the org.apache.commons.beanutils.locale > > package have been checked in to CVS with the wrong line ends. > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>