DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16736>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16736

html:form Focus-Script should check for disabled input field

           Summary: html:form Focus-Script should check for disabled input
                    field
           Product: Struts
           Version: Nightly Build
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Other
         Component: Custom Tags
        AssignedTo: [EMAIL PROTECTED]
        ReportedBy: [EMAIL PROTECTED]


The <html:form>-Tag generates a script which sets focus to the input field 
specified by focus-attribute.

This script checks if the input is hidden and in that case doesn't set the 
focus (because doing so would result in an error reported by the browser).

This behaviour could easily be enhanced to check also if the input field is 
disabled. This also causes an error in the browser (tested with IE 6 SP1).

I have appended a patch that will implement the enhancement:

Index: src/share/org/apache/struts/taglib/html/FormTag.java
===================================================================
RCS file: /home/cvspublic/jakarta-
struts/src/share/org/apache/struts/taglib/html/FormTag.java,v
retrieving revision 1.43
diff -r1.43 FormTag.java
647c647
<             results.append("  if (focusControl.type != \"hidden\") {\r\n");
---
>             results.append("  if (focusControl.type != \"hidden\" && !
focusControl.disabled) {\r\n");

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to