DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17838>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17838

<bean:message> should trim keys before dereferencing





------- Additional Comments From [EMAIL PROTECTED]  2003-03-10 18:57 -------
I've fixed this locally and verified with our new taglib tests (WOOHOO!!!) so
I'll commit this and close it out tonight.




...
...
    [junit] Testcase: testMessageTagNoArgNamePropertySessionScopeAlternateBundle
took 0.07 sec
    [junit] Testcase: testMessageTagNoArgNamePropertyRequestScopeAlternateBundle
took 0.03 sec
    [junit] Running org.apache.struts.taglib.bean.TestMessageTag1
     [java] org.apache.jasper.JasperException: Missing message for key
default.bundle.message.1 
     [java]     at
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:248)
     [java]     at
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:295)
...
...



Then add key.trim() in 2 strategic places:

...
...
    [junit] Testcase:
testMessageTagNoArgNamePropertyApplicationScopeAlternateBundle took 0.06 sec
    [junit] Testcase: testMessageTagNoArgNamePropertySessionScopeAlternateBundle
took 0.07 sec
    [junit] Testcase: testMessageTagNoArgNamePropertyRequestScopeAlternateBundle
took 0.07 sec
    [junit] Running org.apache.struts.taglib.bean.TestMessageTag1
    [junit] Tests run: 24, Failures: 0, Errors: 0, Time elapsed: 4.477 sec
    [junit] Testsuite: org.apache.struts.taglib.bean.TestMessageTag1
    [junit] Tests run: 24, Failures: 0, Errors: 0, Time elapsed: 4.477 sec

    [junit] Testcase: testMessageTag1ArgKeyNoScopeDefaultBundle took 3.115 sec
    [junit] Testcase: testMessageTag1ArgKeyApplicationScopeDefaultBundle took
0.05 sec
...
...



My next question is this:
What about locale (when specified)?

Would it make sense to also trim that string when passed in as well?

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to