DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18583>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18583

Logic equals creates exceptions in normal flow 

           Summary: Logic equals creates exceptions in normal flow
           Product: Struts
           Version: 1.1 RC1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: Custom Tags
        AssignedTo: [EMAIL PROTECTED]
        ReportedBy: [EMAIL PROTECTED]


Logic equals extends CompareTagBase.

In compare tag base data type is determined by conversion attempts:

try {
    doubleValue = Double.parseDouble(value);
    type = DOUBLE_COMPARE;
} catch (NumberFormatException e) {
    ;
}

Most of our equals tests are strings or boolean.
This uses alot of CPU on most JVMs.
Functions to validated type would be cheaper.
I realize that functions are harder to write.

Also this use of exceptions is non idiomatic.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to