--- Robert Leland <[EMAIL PROTECTED]> wrote: > David Graham wrote: > > >--- Steve Raeburn <[EMAIL PROTECTED]> wrote: > > > > > >>o.a.s.util.GenericDataSource is in the core and extends the legacy > >>GenericDataSource so legacy needs to be built first. > >> > >> > > > >That's a good point. > > > > > > > >>It is deprecated since 1.1. Can we get rid of all legacy / DataSource > >>stuff > >>for 1.2? > >> > >> > > > >I believe that was the plan all along but I've been waiting for Ted to > >remove it because he (thankfully :-) took the lead in adding it. I > >haven't looked into it but hopefully it will be a simple build.xml > change > >and removal from cvs. > > > The cleaning up the DTD, docs and then maybe example app ?
I don't think we're removing/changing anything in the DTD. I did make the <data-source type=""> attribute REQUIRED for 1.2 so we don't default to GenericDataSource but AFAIK we're still supporting the <data-source> element. David > > Rob > > > > >David > > > > > > > >>Steve > >> > >> > >> > >>>-----Original Message----- > >>>From: David Graham [mailto:[EMAIL PROTECTED] > >>>Sent: August 9, 2003 4:03 PM > >>>To: Struts Developers List > >>>Subject: Building contrib packages WAS Re: cvs commit: > >>>jakarta-struts/contrib/tag-doc build.xml > >>> > >>> > >>>While we're somewhat on this topic I'd like to get some clarification > >>> > >>> > >>on > >> > >> > >>>the build process. Why do struts-el and struts-legacy get built with > >>> > >>> > >>the > >> > >> > >>>standard Struts build file? Struts-EL has *never* built on my > machine > >>> > >>> > >>and > >> > >> > >>>I have just taken it on faith the rest of Struts built properly. > >>> > >>> > >>Also, > >> > >> > >>>after struts-legacy was added I've had to run my builds twice. The > >>> > >>> > >>first > >> > >> > >>>one always fails and the second succeeds (well, not really succeeds > >>>because struts-el fails). > >>> > >>>In general, I don't see a reason for contrib packages to be built > with > >>> > >>> > >>the > >> > >> > >>>rest of Struts. Am I missing something? > >>> > >>>David > >>> > >>>--- [EMAIL PROTECTED] wrote: > >>> > >>> > >>>>craigmcc 2003/08/09 12:29:30 > >>>> > >>>> Modified: . build.xml > >>>> contrib/struts-el build.xml > >>>> > >>>>contrib/struts-el/src/share/org/apache/strutsel/taglib/html > >>>> ELFormTag.java ELHtmlTag.java > >>>> ELJavascriptValidatorTag.java > >>>> contrib/struts-faces build.xml > >>>> contrib/struts-legacy build.xml > >>>> contrib/tag-doc build.xml > >>>> Log: > >>>> Correct loading order of properties files to go from most local > >>>>(current > >>>> directory) to most global (${user.home}/build.properties). Since > >>>> > >>>> > >>Ant > >> > >> > >>>> follows a "first definition wins" strategy, this makes the most > >>>> > >>>> > >>sense > >> > >> > >>>> for our convention of allowing local overrides of global values. > >>>> > >>>> > >>It > >> > >> > >>>>also > >>>> means that I can now do an "ant dist" in the top level directory > >>>> > >>>> > >>with > >> > >> > >>>>only > >>>> one thing in my build.properties file (jdk.version=1.4), so this > >>>>should fix > >>>> the nightly builds as well (verifying that is my next step). > >>>> > >>>> Also fixed some compile errors in struts-el -- I don't know how > >>>> > >>>> > >>that > >> > >> > >>>>code > >>>> could have compiled for anyone. Could someone more familiar with > >>>> > >>>> > >>that > >> > >> > >>>> library make sure I did the changes correctly? > >>>> > >>>> Revision Changes Path > >>>> 1.118 +5 -2 jakarta-struts/build.xml > >>>> > >>>> Index: build.xml > >>>> > >>>> > >>>> > >>=================================================================== > >> > >> > >>>> RCS file: /home/cvs/jakarta-struts/build.xml,v > >>>> retrieving revision 1.117 > >>>> retrieving revision 1.118 > >>>> diff -u -r1.117 -r1.118 > >>>> --- build.xml 8 Aug 2003 06:00:55 -0000 1.117 > >>>> +++ build.xml 9 Aug 2003 19:29:30 -0000 1.118 > >>>> @@ -113,9 +113,9 @@ > >>>> --> > >>>> > >>>> <!-- Load local and user build preferences --> > >>>> - <property file="${user.home}/build.properties"/> > >>>> - <property file="../build.properties"/> > >>>> <property file="build.properties"/> > >>>> + <property file="../build.properties"/> > >>>> + <property file="${user.home}/build.properties"/> > >>>> > >>>> <!-- Default values for unspecified properties --> > >>>> <property name="catalina.home" > >>>>value="../jakarta-tomcat-4.0/build"/> > >>>> @@ -204,6 +204,9 @@ > >>>> > >>>> <!-- Web directory --> > >>>> <property name="web.dir" value="web"/> > >>>> + > >>>> + <!-- Pointer to struts-legacy.jar --> > >>>> + <property name="struts-legacy.jar" > >>>>value="${basedir}/contrib/struts-legacy/dist/struts-legacy.jar"/> > >>>> > >>>> <!-- Compilation Classpath --> > >>>> <path id="compile.classpath"> > >>>> > >>>> > >>>> > >>>> 1.17 +4 -4 jakarta-struts/contrib/struts-el/build.xml > >>>> > >>>> Index: build.xml > >>>> > === message truncated === __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
