David Graham wrote:

--- Robert Leland <[EMAIL PROTECTED]> wrote:


David Graham wrote:



--- Robert Leland <[EMAIL PROTECTED]> wrote:




[EMAIL PROTECTED] wrote:

David,

I thought you were going to back this out ?




The conversation was left with me proposing a solution and asking for Martin's thoughts on it. He hasn't responded so I haven't backed it


out.


Saving messages in the session is a commonly requested feature (and one
that I need) so I think it needs a solution.




If the solution can automatically clean up after itself, no matter what scenario that is thrown at it, then I am +1.
If there is *--any--* usecase where the session can be left with the messages still in the session, then I am -1.
What ever goes into the session must be explicitly managed, which is usually handled from
the struts-config.xml, such as the ActionForm lifecycle.



I know of two options:


1.  Add a "remove" attribute to <html:messages> so it will remove the
messages when it's finished rendering.

2.  Use something like SingleUseActionMessages which will remain in the
session until overwritten but will only return messages once.

Option 1 wasn't popular under the tags-shouldn't-alter-session-state
philosophy. Option 2 does leave the messages in the session but they're
harmless after the first use. I don't care which one we go with but
storing messages in the session *is* a needed feature so we do need a
solution.


It is quite cear from what Martin stated that option 2 also does meet the requirements, nor mine.
Until a satisfactory solution can be enginered the method needs to be removed* , now.*
There have been two -1's on this.


David





--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to