DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23971>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=23971 Declare log variables protected static ------- Additional Comments From [EMAIL PROTECTED] 2003-10-23 20:23 ------- On further investigation, it's more apparent to me that a potentially large number of applications (at least three that I know of) using Struts might be using the log facility of Struts Actions (or ActionDispatchers) in a way that is somewhat based on similar assumption. There is little reason to blame them because it wasn't and isn't obvious from the docs or usage notes. That brings us to: (a) Craig idea seems to be different as he stated in the Struts-User list sometime back (opening this issue was his suggestion in a way) http://www.mail-archive.com/[EMAIL PROTECTED]/msg83339.html. (b) In case, log instances are marked private the way David suggests, backward compatibity would be broken in the cases mentioned above. (c) We can/could consider a method like getLog() that exposes a reference to the log instance (d) We'd assume apps written for Struts 1.x won't be compatible with Struts 2.x without major change in the code-base of user apps. [which is sort of evident and OK - else this compatibility thing would tend to pull things back in some situation where fresh design and approach would otherwise be necessary]. (e) A general documentation/overview of how to use the internal log would be helpful (more so because they would turn private). Maybe, a section or two in the Struts UserGuide with cross reference to http://jakarta.apache.org/commons/logging/userguide.html would be helpful for Developers at large using Struts. [I can file a new 'Enhancement' ticket for this one if we agree]. (f) We need to start compiling a list incompatibilities that we'd have between Struts 1.x and 2.x. This would be an ongoing process and maybe we can have a whiteboard in the Apache Wiki site (probably with a cross reference from http://jakarta.apache.org/struts/status.html). --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]