I agree that the content (in terms of what fields are useful) of the toString() ouput will vary and is subject to the programmer's descretion but the format in which it is output should be fairly consistent. Maybe I'm just anal but I don't like to see a mix of toString formats in a single codebase.
-- Norm Deane MIS Consultant Vanderbilt University (615) 322-7855 [EMAIL PROTECTED] > -----Original Message----- > From: David Graham [mailto:[EMAIL PROTECTED] > Sent: Thursday, November 06, 2003 12:48 PM > To: Struts Developers List > Subject: RE: Conversion to ToStringBuilder > > > > --- Norm Deane <[EMAIL PROTECTED]> wrote: > > Ok. The nice thing about ToStringBuilder is that it ensures > > consistency across all your toString methods and provides > the ability > > to adopt a new toString style without changing a lot of code. > > I don't see the need for this. toString() implementations > must vary depending on their use. For example, List > implementations generally use "[item1,item2]" while other > classes just want to output some debugging information. > > David > > > > > -- > > Norm Deane > > MIS Consultant > > Vanderbilt University > > (615) 322-7855 > > [EMAIL PROTECTED] > > > > > -----Original Message----- > > > From: David Graham [mailto:[EMAIL PROTECTED] > > > Sent: Thursday, November 06, 2003 10:26 AM > > > To: Struts Developers List > > > Subject: Re: Conversion to ToStringBuilder > > > > > > > > > I think we inherit the dependency on commons lang from some > > > other component. Our use of lang's features is very limited > > > and my preference is to keep it that way. Regardless, > > > toString() is easy to implement without ToStringBuilder. > > > > > > David > > > > > > --- Norm Deane <[EMAIL PROTECTED]> wrote: > > > > I was thinking about adding a toString method to > > > ModuleConfigImpl that > > > > used ToStringBuilder but I noticed some of the other config > > > > objects > > > > have toString > > > > methods that do not use ToStringBuilder. Anyone object to > > > me writing a > > > > patch that converts the existing toString methods to use > > > ToStringBuilder > > > > and > > > > adding one to ModuleConfigImpl? > > > > > > > > --Norm > > > > > > > > -- > > > > Norm Deane > > > > MIS Consultant > > > > Vanderbilt University > > > > (615) 322-7855 > > > > [EMAIL PROTECTED] > > > > > > > > > > > > > > > > -------------------------------------------------------------------- > > > - > > > > To unsubscribe, e-mail: > [EMAIL PROTECTED] > > > > For additional commands, e-mail: > > > > [EMAIL PROTECTED] > > > > > > > > > > > > > __________________________________ > > > Do you Yahoo!? > > > Protect your identity with Yahoo! Mail AddressGuard > > > http://antispam.yahoo.com/whatsnewfree > > > > > > > > > > -------------------------------------------------------------------- > > > - > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: > [EMAIL PROTECTED] > > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > __________________________________ > Do you Yahoo!? > Protect your identity with Yahoo! Mail AddressGuard > http://antispam.yahoo.com/whatsnewfree > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]