Hi! First of all, I think struts-menu is a great contribution and hope it will be integrated into struts some day. We need a good set of menu tags to create stunning out-of-the-box menus for our Java apps, so keep up the good work!
Also, apologies if some (or all :) of my rantings are invalid, as I am a total newbie when it comes to struts-menu :) However, testing the examples at http://raibledesigns.com/struts-menu, I notice that both Basic, Coolmenu4 and Dropdown has issues. - With Basic, I get the string "null" after each menu item. Noticed that this already has been reported as a bug on sourceforge, though. - With Coolmenu4, the item heights are too small causing menu items to be "cut off" (not all of the item is visible). Will put up a page with a screenshot to illustrate this. - Dropdown just plainly doesn't drop down at all :) I have tested this with both Epiphany 1.0.1 (mozilla 1.4.x) and IE 6.0. Note: Dave Lindquist´s dropdown example (http://www.gazingus.org/dhtml/? id=109) works without a glitch. Using W3C:s validator (http://validator.w3.org), Dave Lindquist's example is validated OK while the struts-menu Dropdown example generates errors. These errors may give a hint on why DL's example works and SM doesn't - haven't looked into it yet. A suggestion (while I'm at it :) ) - what about trying to make struts-menu generate the <link rel="stylesheet" type="text/css" media="screen" href="styles/menuDropdown.css" /> <script type="text/javascript" src="scripts/menuDropdown.js"></script> portion in the HEAD section? That would reduce the amount of code having to be written in the JSP. Also, a <menu:disableCSS text="Disable stylesheets"/> tag for easy insertion of a link to a CSS disabled version of the page seems like a nifty thing to add. This is just from the top of my head, I will start looking further into struts-menu soon to find other areas for improvement. Cheers, - Mikael. ____________________________________________________________ Vad står det om dig på nätet? - http://www.lycos.se/
