Yeah, it would be an additional feature, not a bug fix. Thanks for your speedy replies.
Best wishes, Shawn -----Original Message----- From: David Graham [mailto:[EMAIL PROTECTED] Sent: Thursday, June 19, 2003 11:43 PM To: [EMAIL PROTECTED] Subject: RE: Problem with RewriteTag RC2 and Websphere >Thanks. Does a redirect property on the Link Tag make sense, so that >for any Link tag, one can determine whether encodeURL or >encodeRedirectURL is called? I'm not sure, the link tag seems to work fine as it is. It would be a post 1.1 enhancement regardless. David > >s. > >-----Original Message----- >From: David Graham [mailto:[EMAIL PROTECTED] >Sent: Thursday, June 19, 2003 11:31 PM >To: [EMAIL PROTECTED] >Subject: Re: Problem with RewriteTag RC2 and Websphere > > >I am in the process of fixing this problem right now (and that comment >was mine not Craig's :-). > > >David > > >There was a change to the implementation of the RewriteTag in RC2 > >regarding the way RequestUtils.computeURL() is called. Rather than > >passing redirect as false, redirect is now passed as !this.isXhtml(). > >WebSphere has a clear implementation of encodeURL() vs. > >encodeRedirectURL(). encodeRedirectURL() will always include the > >contextPath. So, when rewrite calls computeURL, computeURL appends > >getContextPath() to the URL and then calls encodeRedirectURL() which > >also includes the contextPath, so I end up with > >http://my.company.com:8080/ContextRoot/ContextRoot/path/to/css > > > >The upshot of this is that my html:rewrite tags (used for css > >stylesheets, etc.) no longer work on WebSphere under RC2 unless I > >implement Xhtml. I have not tested other web app servers. > > > >I have read Craig's comment in the source code: > >// Note that we're encoding the & character to & in XHTML mode > >only, > > > >// otherwise the & is written as is to work in javascripts. > > > >Unless I am missing something, I don't understand why the redirect > >parameter is being set based on isXhtml(). My assumption is that > >Tomcat or other webapp servers implement encodeRedirectURL() in the > >same way as > >encodeURL() so that this change is not affecting other users of RC2 > >in the same way. > > > >It seems to me that the Link tag (superclass of the rewrite tag) > >should > > >have a redirect attribute, so that one can determine from the JSP how > >the URL is encoded. > > > >Any clarification on this point would be helpful. For now, I created > >a > > >custom tag using the source code for the RC1 release of RewriteTag. > > > > > >--------------------------------------------------------------------- > >To unsubscribe, e-mail: [EMAIL PROTECTED] > >For additional commands, e-mail: [EMAIL PROTECTED] > > > >_________________________________________________________________ >Tired of spam? Get advanced junk mail protection with MSN 8. >http://join.msn.com/?page=features/junkmail > > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] > > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] > _________________________________________________________________ MSN 8 with e-mail virus protection service: 2 months FREE* http://join.msn.com/?page=features/virus --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
