** Description changed: [Impact] The juju plugin will stop and start the juju-db service during data collection. sosreport should not impact running services, or attempt to recover them. - This has been reported upstream and will be fixed by the juju 2.x refactor: - https://github.com/sosreport/sos/issues/1653 + This has been reported upstream[0] and will be fixed by the juju 2.x + refactor[1] - This is a stop-gap tracking the removal of the juju-db service restart code in - existing sosreport releases. - + This is a stop-gap tracking the removal of the juju-db service restart + code in existing sosreport releases. + + [0] - https://github.com/sosreport/sos/issues/1653 + [1] - https://github.com/sosreport/sos/pull/1670 + [Test Case] - * Install sosreport - * Run sosreport, ensuring that the juju plugin is exercised. - * Confirm the juju-db service was not restarted, and mongoexport data captured. + * Install sosreport + * Look mongod PID before + ** pidof mongod + * Run sosreport, ensuring that the juju plugin is exercised + * Confirm the juju-db service was not restarted, and mongoexport data captured. + * Look mongod PID after + ** pidof mongod Check for errors while running, or in /tmp/sosreport-*/sos_logs/ + The offending function ensure_service_is_running() in theory doesn't create any harm unless juju plugin is exercised during a sosreport run from a juju controller where mongod and juju-db reside. + + [Regression Potential] - * Risk is low. - * Change is limited in scope to the juju plugin. - * Worst-case scenario is that the mongoexport command will fail to collect - any data. + * Risk is low. + * Change is limited in scope to the juju plugin. + * Worst-case scenario is that the mongoexport command will fail to collect + any data.
-- You received this bug notification because you are a member of STS Sponsors, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1828467 Title: [sru] remove juju-db stop/start service interactions Status in sosreport package in Ubuntu: In Progress Status in sosreport source package in Trusty: New Status in sosreport source package in Xenial: New Status in sosreport source package in Bionic: New Status in sosreport source package in Cosmic: New Status in sosreport source package in Disco: New Status in sosreport source package in Eoan: In Progress Bug description: [Impact] The juju plugin will stop and start the juju-db service during data collection. sosreport should not impact running services, or attempt to recover them. This has been reported upstream[0] and will be fixed by the juju 2.x refactor[1] This is a stop-gap tracking the removal of the juju-db service restart code in existing sosreport releases. [0] - https://github.com/sosreport/sos/issues/1653 [1] - https://github.com/sosreport/sos/pull/1670 [Test Case] * Install sosreport * Look mongod PID before ** pidof mongod * Run sosreport, ensuring that the juju plugin is exercised * Confirm the juju-db service was not restarted, and mongoexport data captured. * Look mongod PID after ** pidof mongod Check for errors while running, or in /tmp/sosreport-*/sos_logs/ The offending function ensure_service_is_running() in theory doesn't create any harm unless juju plugin is exercised during a sosreport run from a juju controller where mongod and juju-db reside. [Regression Potential] * Risk is low. * Change is limited in scope to the juju plugin. * Worst-case scenario is that the mongoexport command will fail to collect any data. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/sosreport/+bug/1828467/+subscriptions -- Mailing list: https://launchpad.net/~sts-sponsors Post to : [email protected] Unsubscribe : https://launchpad.net/~sts-sponsors More help : https://help.launchpad.net/ListHelp
