Dariusz, As part of my learning homework to be able to technically review the patch in this proposal,
I came across three things that may be useful for the bug description/SRU template, so I'll just add them, if you don't mind. 1) Understanding the scenario where the bug happens (mod-wsgi running in daemon mode/not embedded mode, only the former uses sockets; and reload/not-restart apache2 between HTTP requests in the same keep-alive connection) [1, 2]. 2) Detailed steps to reproduce/verify the bug. 3) Confirming that the default behavior with the patch remains as in the previous version (of course, as it should/is supposed to, but it's worth mentioning in bug description :-) With all those points now understood/verified, I'll proceed with the upload for SRU to B/X. Thanks! cheers, Mauricio [1] https://github.com/GrahamDumpleton/mod_wsgi/commit/13169f2a0610d7451fae92a414e8e20b91e348c9#diff-3e8b16b2885169dcec2dac843521e12cR29 [2] https://modwsgi.readthedocs.io/en/develop/user-guides/quick-configuration-guide.html#delegation-to-daemon-process -- You received this bug notification because you are a member of STS Sponsors, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1863232 Title: daemon rotates socket on restart Status in mod-wsgi package in Ubuntu: Fix Released Status in mod-wsgi source package in Xenial: In Progress Status in mod-wsgi source package in Bionic: In Progress Bug description: [Impact] * Lack of option for disabling wsgi socket rotation leads to errors on graceful restarts, making them not as graceful. * This change introduces a new config option WSGISocketRotation that allows to disable the rotation. [Test Case] * Setup apache2 with mod-wsgi. * Make sure there are some wsgi sockets open. * Reload apache gracefully. Expected result: No errors related to sockets in the logs Actual result: There are error messages related to sockets in the logs. [Regression Potential] * Since the value is set to On by default any regressions would manifest only after explicitly setting it to Off. * After it's set to off WSGI application behavior will change on reloads - connections should be resumed instead of cancelled. [Other Info] * Original bug description: On Apache reloads the WSGI daemon tries to rotate wsgi sockets causing unnecessary log entries, especially in OpenStack context. This has been addressed in mod-wsgi upstream (4.6.0) and could be backported to Ubuntu. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/mod-wsgi/+bug/1863232/+subscriptions -- Mailing list: https://launchpad.net/~sts-sponsors Post to : [email protected] Unsubscribe : https://launchpad.net/~sts-sponsors More help : https://help.launchpad.net/ListHelp
