@joalif thank you for the debdiff! There are some minor nitpicks about the patch file that I'd like to confirm with you:
- The 'Origin:' tag in your patch file seems to be missing the patch identifier. From the commit id, would it be appropriate to point it towards [0]? - I've seen you added a line that says "Backported from upstream commit <snip>". If this required changes, please adjust the 'Origin:' tag with a "backport" prefix instead of "upstream" (you could then omit that additional line) [0] https://git.kernel.org/pub/scm/utils/trace-cmd/trace- cmd.git/commit/?id=1375d98d8017 -- You received this bug notification because you are a member of STS Sponsors, which is subscribed to the bug report. https://bugs.launchpad.net/bugs/1955129 Title: trace-cmd report buffer overflow detected Status in trace-cmd package in Ubuntu: In Progress Status in trace-cmd source package in Bionic: In Progress Bug description: [IMPACT] When running trace-cmd report on Bionic it crashes with *** buffer overflow detected ***: trace-cmd terminated Aborted (core dumped) [TEST CASE] Prepare a simple script to trace e.g. : #!/usr/bin/python import socket s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) s.close() then $ sudo trace-cmd record -a -p function_graph -g __fput -g sock_close -g tcp_close python2 ./close.py $ sudo trace-cmd report The latter will fail with buffer overflow detected [WHERE THINGS COULD GO WRONG] The fixing commit changes the size of a buffer from 20 to 24 in arg_eval() function to avoid buffer overflow. Any potential regression would occur in that function. [OTHER] Only Bionic is affected, it is fixed in newer releases. Fix upstream commit 1375d98d8017e371776adbef10122a57ce2100e5 To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/trace-cmd/+bug/1955129/+subscriptions -- Mailing list: https://launchpad.net/~sts-sponsors Post to : [email protected] Unsubscribe : https://launchpad.net/~sts-sponsors More help : https://help.launchpad.net/ListHelp
