Review: Approve +1, with a nit inline
Diff comments: > diff --git a/src/maasserver/websockets/handlers/controller.py > b/src/maasserver/websockets/handlers/controller.py > index 0e54ff9..53884d0 100644 > --- a/src/maasserver/websockets/handlers/controller.py > +++ b/src/maasserver/websockets/handlers/controller.py > @@ -123,6 +123,7 @@ class ControllerHandler(NodeHandler): > "hostname", > "domain", > "node_type", > + "node_type_display", this shouldn't be needed, this is the list of model fields (or handler properties) to automatically include, and node_type_display is a computed one > "status", > "last_image_sync", > "cpu_count", -- https://code.launchpad.net/~lloydwaltersj/maas/+git/maas/+merge/435593 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : [email protected] Unsubscribe : https://launchpad.net/~sts-sponsors More help : https://help.launchpad.net/ListHelp
