Re: [Sts-sponsors] [Merge] ~thorsten-merten/maas-site-manager:MAASENG-1497-pagination into maas-site-manager:main

[Alberto Donato]

Diff comments:

> diff --git a/backend/msm/__init__.py b/backend/msm/__init__.py
> index 8506985..59066fb 100644
> --- a/backend/msm/__init__.py
> +++ b/backend/msm/__init__.py
> @@ -1,8 +1,16 @@
>  from pkg_resources import get_distribution
>  
> -__all__ = ["PACKAGE", "__version__"]
> +__all__ = [
> +    "PACKAGE",
> +    "__version__",
> +    "_default_page_size",
> +    "_max_page_size",
> +]
>  
>  
>  PACKAGE = get_distribution("msm")
>  
>  __version__ = PACKAGE.version
> +
> +_default_page_size = 20
> +_max_page_size = 100

it's a bit strange to have private exported constants. I'd drop the leading _, 
and make the names uppercase



-- 
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/439629
Your team MAAS Committers is subscribed to branch 
~thorsten-merten/maas-site-manager:MAASENG-1497-pagination.


-- 
Mailing list: https://launchpad.net/~sts-sponsors
Post to     : sts-sponsors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~sts-sponsors
More help   : https://help.launchpad.net/ListHelp