Review: Needs Information See small nit and a question inline
Diff comments: > diff --git a/src/provisioningserver/utils/arch.py > b/src/provisioningserver/utils/arch.py > index a195ea2..9998201 100644 > --- a/src/provisioningserver/utils/arch.py > +++ b/src/provisioningserver/utils/arch.py > @@ -6,6 +6,22 @@ > from functools import lru_cache > import os > > +# Architectures as defined by: > +# https://github.com/lxc/lxd/blob/master/shared/osarch/architectures.go > +# https://www.debian.org/releases/oldstable/i386/ch02s01.html.en Let's maybe update this to https://www.debian.org/releases/bullseye/amd64/ch02s01.en.html, since the link is dead? > +DEBIAN_TO_KERNEL_ARCHITECTURES = { > + "i386/generic": "i686", I have some doubts over having "/generic" appended each time we want to convert the architectures. The debian page linked does not specify "generic" anywhere except for a `s390x` flavour. Is this "generic" suffix really needed, given that there are no entries that have same architecture but different suffixes (amd64/generic -> amd64 vs amd64/whatever -> amd65)? > + "amd64/generic": "x86_64", > + "arm64/generic": "aarch64", > + "ppc64el/generic": "ppc64le", > + "s390x/generic": "s390x", > + "mips/generic": "mips", > + "mips64el/generic": "mips64", > +} > +KERNEL_TO_DEBIAN_ARCHITECTURES = { > + v: k for k, v in DEBIAN_TO_KERNEL_ARCHITECTURES.items() > +} > + > > @lru_cache(maxsize=1) > def get_architecture(): -- https://code.launchpad.net/~ack/maas/+git/maas/+merge/439920 Your team MAAS Committers is subscribed to branch maas:master. -- Mailing list: https://launchpad.net/~sts-sponsors Post to : [email protected] Unsubscribe : https://launchpad.net/~sts-sponsors More help : https://help.launchpad.net/ListHelp
